Use Modal's onDismiss to prevent Alert bug#22
Open
Ashoat wants to merge 1 commit intowookoinc:masterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is an annoying issue in React Native where if you call an
Alertright as aModalis being closed, it can crash the UI thread: facebook/react-native#10471The solution, which is available in RN 0.50, is a new callback property on
ModalcalledonDismiss. CallingAlertfrom within this callback is safe.This PR makes it so this component calls the user callback from within
onDismiss. It should have no impact if the user is not callingAlert.