Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initial checklist
Description of changes
tryStatSynchas a note thatthrowIfNoEntry: falsecan be used from Node 15. Every supported Node (the package already usesstatSync(url, {throwIfNoEntry: false})a few lines further down inlib/resolve.js) has it, so this switchestryStatSyncto it. Return values are unchanged (undefinedfor a missing path; other errors are still swallowed by the existingcatch).Why it matters: resolution probes many paths that do not exist (every
node_modules/<pkg>/package.jsonup the tree). Each miss currently allocates an ENOENT error and captures a stack trace just to be thrown away.import-meta-resolveis inlined bymlly, which is bundled byjiti(used by Nuxt, Tailwind, ESLint, pi, ...), so this hits every TypeScript extension/config load there.Measured:
throwIfNoEntry: false.Tests: added a test that a missing package still ends in
ERR_MODULE_NOT_FOUNDafter walking up everynode_modules(covers the changed code path).node test/index.js: 4 pass.