Patching guides and traveler in from gcsim

[woopxwoop]

Summary by CodeRabbit

• New Features
  • Character pages now show investment recommendations from editorial guides, with simulation data used when guide details are unavailable.
  • Recommendations include talents, level 90, constellations, and signature weapons, with clearer impact classifications and source indicators.
  • Traveler builds now correctly support Anemo, Dendro, Electro, Geo, Hydro, and Pyro variants.
• Bug Fixes
  • Upgrade impact details now display safely when measurement data is incomplete.
  • Removed the meta-team usage-rate label from character pages.

[coderabbitai]

Warning

Review limit reached

@woopxwoop, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 43 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: Repository UI (base), Organization UI (inherited)

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: ac6b4212-3eb0-40bf-991b-9eba244504fe

📥 Commits

Reviewing files that changed from the base of the PR and between d5adb64 and e8402ec.

📒 Files selected for processing (1)

• src/routes/characters/[slug]/+page.svelte

📝 Walkthrough

Walkthrough

Character investment recommendations now select between authored guide priorities and measured simulation data. Traveler keys resolve by element across character data and roster mappings, and the character page renders source-specific priority details and metrics.

Changes

Character recommendation flow

Layer / File(s)	Summary
Guide priority contracts and impact resolution src/lib/types/investment.ts, src/lib/upgrade-priority.ts, src/lib/character-builds.ts	Adds guide-priority configuration, section result types, and tier-based impact resolution.
Element-specific Traveler identity src/lib/data/character-bases.json, src/lib/utils.ts, src/lib/utils.traveler.test.ts, src/routes/characters/[slug]/+page.server.ts, src/routes/characters/[slug]/+page.svelte	Adds elemental Traveler records and resolves Traveler keys across simulation, roster, ownership, and page lookups.
Guide and simulation section selection src/lib/character-builds.ts, src/lib/character-builds.test.ts	Selects guide or simulation talent, level, constellation, and signature-weapon recommendations according to overrides and available measurements.
Character-page recommendation rendering src/routes/characters/[slug]/+page.svelte, src/lib/ui/components/UpgradeImpactPopover.svelte	Renders qualitative guide priorities, measured simulation metrics, missing-data indicators, and reusable constellation and weapon rows.

Estimated code review effort: 4 (Complex) | ~45 minutes

Sequence Diagram(s)

sequenceDiagram
  participant CharacterPage
  participant PrioritySections
  participant SimulationData
  participant GuidePriority
  CharacterPage->>PrioritySections: request investment recommendations
  PrioritySections->>GuidePriority: read guide priorities and overrides
  PrioritySections->>SimulationData: inspect measured priorities and team counts
  PrioritySections-->>CharacterPage: return guide or simulation sections
  CharacterPage->>UpgradeImpactPopover: render available impact metrics

Loading

Possibly related PRs

• woopxwoop/lightkeepers#24: Introduced the character-page and investment data surfaces extended here.
• woopxwoop/lightkeepers#30: Shares upgrade-impact and character recommendation UI changes.
• woopxwoop/lightkeepers#32: Introduced reusable character-build transformation helpers extended by this change.

Poem

A rabbit hops through guides and stats,
Sorting talents, bows, and hats.
Travelers shift from flame to stone,
Each elemental key is known.
“Measured or guided—show the way!”
Then carrot-bright priorities stay.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 75.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly summarizes the pull request’s main changes: adding guide support and Traveler integration from gcsim.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches 💡 1

📝 Generate docstrings 💡

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch Patches

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@src/routes/characters/`[slug]/+page.svelte:
- Around line 918-975: Extract a reusable `talentRow` snippet for the shared
rank, icon, and name markup, parameterized for optional `data-priority` and
`UpgradeImpactPopover` content. Replace both sim and guide branches in the
talent section and the corresponding duplicated level-section branches with
calls to this snippet, following the existing `consRow`/`sigRow` pattern while
preserving their distinct attributes and popover behavior.
- Around line 354-427: Update the consRow and sigRow snippets to accept a single
typed object containing the row identity fields and optional impact statistics
instead of positional parameters. Adjust all render call sites to pass the
appropriate row object, aliasing VerticalImpactRow *_pct_gain fields where
needed and preserving guide-row defaults; ensure UpgradeImpactPopover receives
the object’s named statistics.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository UI (base), Organization UI (inherited)

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 9a43e7a9-bc35-4087-8d7b-176228684a65

📥 Commits

Reviewing files that changed from the base of the PR and between 3e54853 and d5adb64.

⛔ Files ignored due to path filters (2)

• .github/workflows/deploy.yml is excluded by none and included by none
• prometheus.yml is excluded by none and included by none

📒 Files selected for processing (10)

• src/lib/character-builds.test.ts
• src/lib/character-builds.ts
• src/lib/data/character-bases.json
• src/lib/types/investment.ts
• src/lib/ui/components/UpgradeImpactPopover.svelte
• src/lib/upgrade-priority.ts
• src/lib/utils.traveler.test.ts
• src/lib/utils.ts
• src/routes/characters/[slug]/+page.server.ts
• src/routes/characters/[slug]/+page.svelte