Skip to content

feat: Expand VideoPress support #22229

Closed
dcalhoun wants to merge 3 commits intotrunkfrom
chore/test-gutenberg-kit-video-press
Closed

feat: Expand VideoPress support #22229
dcalhoun wants to merge 3 commits intotrunkfrom
chore/test-gutenberg-kit-video-press

Conversation

@dcalhoun
Copy link
Copy Markdown
Member

@dcalhoun dcalhoun commented Sep 24, 2025

Important

DO NOT MERGE. With the merge of wordpress-mobile/GutenbergKit#260, we need to integrate those changes before we can merge this PR.

Description

Integrate GutenbergKit VideoPress support.

Testing instructions

See wordpress-mobile/GutenbergKit#181.

@dcalhoun dcalhoun added [Type] Enhancement Gutenberg Editing and display of Gutenberg blocks. Do Not Merge labels Sep 24, 2025
@dangermattic
Copy link
Copy Markdown
Collaborator

1 Message
📖 This PR is still a Draft: some checks will be skipped.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Copy Markdown
Contributor

wpmobilebot commented Sep 24, 2025

Project dependencies changes

list
! Upgraded Dependencies
org.wordpress.gutenbergkit:android:181-bbaf9c41a4e82514453fc0a398a9521caf8a99b6, (changed from v0.11.1)
tree
 +--- project :libs:editor
-|    \--- org.wordpress.gutenbergkit:android:v0.11.1
+|    \--- org.wordpress.gutenbergkit:android:181-bbaf9c41a4e82514453fc0a398a9521caf8a99b6
-\--- org.wordpress.gutenbergkit:android:v0.11.1 (*)
+\--- org.wordpress.gutenbergkit:android:181-bbaf9c41a4e82514453fc0a398a9521caf8a99b6 (*)

@wpmobilebot
Copy link
Copy Markdown
Contributor

wpmobilebot commented Sep 24, 2025

App Icon📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack
FlavorJalapeno
Build TypeDebug
Versionpr22229-8e7e96d
Commit8e7e96d
Direct Downloadjetpack-prototype-build-pr22229-8e7e96d.apk
Note: Google Login is not supported on these builds.

@wpmobilebot
Copy link
Copy Markdown
Contributor

wpmobilebot commented Sep 24, 2025

App Icon📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress
FlavorJalapeno
Build TypeDebug
Versionpr22229-8e7e96d
Commit8e7e96d
Direct Downloadwordpress-prototype-build-pr22229-8e7e96d.apk
Note: Google Login is not supported on these builds.

@dcalhoun dcalhoun changed the title chore: Test GutenbergKit VideoPress feat: Expand VideoPress support Oct 3, 2025
@dcalhoun dcalhoun force-pushed the chore/test-gutenberg-kit-video-press branch from 16f9a20 to c17e19b Compare October 3, 2025 15:58
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Oct 3, 2025

@dcalhoun dcalhoun force-pushed the chore/test-gutenberg-kit-video-press branch from c17e19b to 8e7e96d Compare January 13, 2026 19:39
@sonarqubecloud
Copy link
Copy Markdown

@codecov
Copy link
Copy Markdown

codecov bot commented Jan 13, 2026

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 39.17%. Comparing base (acd12d8) to head (8e7e96d).
⚠️ Report is 210 commits behind head on trunk.

Files with missing lines Patch % Lines
...ess/android/ui/posts/EditorConfigurationBuilder.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            trunk   #22229      +/-   ##
==========================================
- Coverage   39.17%   39.17%   -0.01%     
==========================================
  Files        2205     2205              
  Lines      106599   106600       +1     
  Branches    15117    15117              
==========================================
  Hits        41761    41761              
- Misses      61339    61340       +1     
  Partials     3499     3499              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dcalhoun
Copy link
Copy Markdown
Member Author

Closing this outdated PR. VideoPress support integration can occur in a new PR later in the form of bumping the GutenbergKit version. Setting the assetLoaderDomain is no longer necessary.

@dcalhoun dcalhoun closed this Mar 28, 2026
@dcalhoun dcalhoun deleted the chore/test-gutenberg-kit-video-press branch March 28, 2026 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Gutenberg Editing and display of Gutenberg blocks. [Type] Enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants