Skip to content

Add docker build to goreleaser #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rocpatel wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add docker build to goreleaser #11

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a0d0507
Add docker build to goreleaser
rocpatel Aug 6, 2024
0bc04a4
Add newline to docker file
rocpatel Aug 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions .github/workflows/release.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,16 @@ jobs:
uses: actions/checkout@v4
with:
fetch-depth: 0
- name: Configure AWS credentials
uses: aws-actions/configure-aws-credentials@v4
with:
aws-region: "us-east-1"
aws-access-key-id: ${{ secrets.AWS_ACCESS_KEY_ID }}
aws-secret-access-key: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
- name: Docker Login
uses: aws-actions/amazon-ecr-login@v2
with:
registry-type: public
- name: Release with GoReleaser
uses: goreleaser/goreleaser-action@v6
with:
Expand Down
11 changes: 9 additions & 2 deletions .goreleaser.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ builds:
- -s -w -X main.version={{.Version}} -X main.commit={{.Commit}} -X main.date={{.Date}}
- id: linux
goos: [linux]
goarch: [386, arm, amd64, arm64]
goarch: ["386", arm, amd64, arm64]
env:
- CGO_ENABLED=0
binary: bin/workos
Expand All @@ -22,7 +22,7 @@ builds:
- -s -w -X main.version={{.Version}} -X main.commit={{.Commit}} -X main.date={{.Date}}
- id: windows
goos: [windows]
goarch: [386, amd64, arm64]
goarch: ["386", amd64, arm64]
binary: bin/workos
main: ./cmd/workos/
ldflags:
Expand Down Expand Up @@ -61,3 +61,10 @@ brews:
commit_author:
name: WorkOS
email: support@workos.com
dockers:
- ids:
- linux
Copy link
Contributor

@kkajla12 kkajla12 Aug 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if it's worth building/publishing images for x86-64 and ARM? (For Windows and ARM machines)

Copy link
Contributor Author

@rocpatel rocpatel Aug 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure, but if the aim is to provide support for ci pipelines, it seems that linux should be enough.

Copy link
Contributor

@kkajla12 kkajla12 Aug 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, in that case, we might need to update the tags in the ECR public gallery because it shows Windows and ARM64 as supported platforms
Screenshot 2024-08-21 at 3 47 59 PM

image_templates:
- "public.ecr.aws/p9s6f8y8/workos-cli:{{.Version}}"
build_flag_templates:
- "--platform=linux/amd64"
3 changes: 3 additions & 0 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
FROM scratch
COPY ./bin/workos /bin/workos
ENTRYPOINT ["/bin/workos"]