fix(ci): remove duplicate pnpm version; correct release date#2
Merged
Conversation
…-05-12 CI was failing on every run: pnpm/action-setup@v4 errors when both 'version: 9' in the workflow AND 'packageManager: pnpm@9.0.0' in package.json are present. Removing the workflow key lets action-setup read packageManager from package.json (the intended source of truth). Also corrects CHANGELOG [0.3.0] date from 2026-05-22 → 2026-05-12.
There was a problem hiding this comment.
Pull request overview
This PR fixes CI configuration and release documentation consistency in the monorepo by removing a redundant pnpm pin in the CI workflow and correcting a mistakenly future-dated changelog entry.
Changes:
- Removed the explicit
version: 9input frompnpm/action-setup@v4in CI to avoid conflicting pnpm version pinning withpackage.json’spackageManager. - Corrected
@workspacejson/specchangelog version0.3.0date from2026-05-22to2026-05-12.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/spec/CHANGELOG.md | Corrects the recorded release date for 0.3.0. |
| .github/workflows/ci.yml | Removes explicit pnpm version pinning so CI can rely on the repo’s packageManager pin. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -17,8 +17,6 @@ jobs: | |||
| - uses: actions/checkout@v4 | |||
|
|
|||
| - uses: pnpm/action-setup@v4 | |||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
version: 9frompnpm/action-setup@v4— thepackageManagerfield inpackage.jsonalready pinspnpm@9.0.0, having both causes a fatal conflict on every CI run[0.3.0]date from2026-05-22→2026-05-12Why this wasn't in the merge
This commit was pushed to
release/v0.3after the PR was merged. Cherry-picked cleanly ontomain.Test plan