Skip to content

feat!: siegel key manager for Safe Smart Account 🧧 #355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
paolodamico wants to merge 5 commits into
base: main
Choose a base branch
from
Open

feat!: siegel key manager for Safe Smart Account 🧧 #355

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
09a7d05
feat: siegel key manager
paolodamico May 15, 2026
039057e
full
paolodamico May 15, 2026
3297eff
minor improvements
paolodamico May 15, 2026
7ba38ef
zeroize it all!
paolodamico May 15, 2026
2a982e8
feedback
paolodamico May 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions bedrock/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,7 @@ x509-cert = { version = "0.2.5", features = ["pem"] }
zeroize = "1.8"
hex-literal = "1.1.0" # Provides the `hex!` macro for compile-time hex decoding
http = "1.4.0"
siegel-uniffi = "0.1.0"
Copy link
Copy Markdown

@NnnOooPppEee NnnOooPppEee May 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

siegel-uniffi = "0.1.0" resolves under Cargo's caret semver to >=0.1.0, <0.2.0 rather than an exact pin, and it's published from the personal paolodamico crates.io account. cargo update or Dependabot can pull a future 0.1.x without code review. For a dep sitting in the EOA signing path that's a wider supply-chain surface than ideal.

Smallest fix: siegel-uniffi = "=0.1.0". Longer term a Worldcoin-owned mirror or namespace transfer would be cleaner.


# TODO: once `rand` can be bumped to 0.9, add the explicit feature flag `os_rng`. this explicitly determines no `thread_rng`;
# bumping this requires crypto_box to update rand: https://github.com/RustCrypto/nacl-compat/issues/176
Expand Down
1 change: 1 addition & 0 deletions bedrock/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,3 +54,4 @@ pub mod siwe;
pub mod test_utils;

uniffi::setup_scaffolding!("bedrock");
siegel_uniffi::uniffi_reexport_scaffolding!();
6 changes: 4 additions & 2 deletions bedrock/src/siwe/test.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ const TEST_KEY: &str =
const TEST_WALLET: &str = "0xd8dA6BF26964aF9D7eEd9e03E53415D37aA96045";

fn test_smart_account() -> SafeSmartAccount {
SafeSmartAccount::new(TEST_KEY.into(), TEST_WALLET).unwrap()
SafeSmartAccount::from_private_key_hex(TEST_KEY.to_string(), TEST_WALLET).unwrap()
}

fn make_valid_message(datetime: &str) -> String {
Expand Down Expand Up @@ -470,7 +470,9 @@ fn parse_accepts_message_at_max_length() {
fn sign_produces_verifiable_signature() {
let signer = PrivateKeySigner::from_str(TEST_KEY).unwrap();
let eoa_address = signer.address();
let account = SafeSmartAccount::new(TEST_KEY.into(), TEST_WALLET).unwrap();
let account =
SafeSmartAccount::from_private_key_hex(TEST_KEY.to_string(), TEST_WALLET)
.unwrap();

let msg = SiweMessage {
scheme: Some(Scheme::HTTPS),
Expand Down
Loading
Loading