test: add e2e test for main legacy USD vault migration, in addition to the no-limit USD vault#356
Open
thomas-waite wants to merge 3 commits into
Open
test: add e2e test for main legacy USD vault migration, in addition to the no-limit USD vault#356thomas-waite wants to merge 3 commits into
thomas-waite wants to merge 3 commits into
Conversation
thomas-waite
requested review from
Dzejkop,
Guardiola31337,
andy-t-wang,
aurel-fr,
karankurbur,
murph,
paolodamico and
sideround
as code owners
thomas-waite
changed the title
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit cda6294. Configure here.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cda62949d2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
thomas-waite
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add e2e test for main legacy USD vault migration, in addition to the no-limit USD vault
There are two legacy USD vaults, no limit and limit. The limit one is the main, production one and the one that will be migrated in prod.
This PR adds it into the e2e tests to make sure it works.
Note
Low Risk
Low risk: changes are isolated to an E2E test and only adjust how test state is prepared and asserted for two legacy vault variants.
Overview
Extends the USDVault migration E2E test to run the same migration scenario against two legacy USD vault contracts (the existing no-limit vault and the main/withdrawals-limited vault).
Refactors the test into a reusable
run_usd_vault_migrationhelper, adds a flag to seed the limited vault’s per-user deposit tracking via direct storage writes, and improves failure reporting withanyhow::Context.Reviewed by Cursor Bugbot for commit 65140ee. Bugbot is set up for automated code reviews on this repo. Configure here.