fix mermaid diagram placement

Cargo.toml

@@ -13,7 +13,7 @@ resolver = "2"
 edition = "2024"
 license = "MIT"
 rust-version = "1.85"
-version = "0.1.37"
+version = "0.1.39"
 
 [workspace.dependencies]
 anyhow = "1"
@@ -34,5 +34,5 @@ proc-macro2 = "1"
 
 # Phase 1: Template embedding
 include_dir = "0.7"
-mobench-macros = { version = "0.1.37", path = "crates/mobench-macros" }
-mobench-sdk = { version = "0.1.37", path = "crates/mobench-sdk", default-features = false }
+mobench-macros = { version = "0.1.39", path = "crates/mobench-macros" }
+mobench-sdk = { version = "0.1.39", path = "crates/mobench-sdk", default-features = false }

README.md

@@ -29,99 +29,6 @@ that CI and humans can compare.
 - Mobile apps call `run_benchmark` via the generated bindings and return timing samples
 - The CLI collects results locally or from BrowserStack and writes summaries
 
-## Workflow diagrams
-
-The Mermaid sources live under `docs/diagrams/` so the same diagrams can be
-reused in launch posts and landing-page assets.
-
-### Crate architecture
-
-```mermaid
-flowchart LR
-    user["Benchmark crate"] --> macro["mobench-macros\n#[benchmark]"]
-    macro --> registry["mobench-sdk registry\ninventory"]
-    registry --> runner["mobench-sdk runner\nBenchSpec -> BenchReport"]
-    runner --> templates["Generated Android/iOS runners"]
-    cli["mobench CLI"] --> builders["SDK builders"]
-    builders --> templates
-    cli --> reports["JSON / Markdown / CSV / plots"]
-    templates --> reports
-```
-
-### Benchmark lifecycle
-
-```mermaid
-sequenceDiagram
-    participant Dev as Developer
-    participant CLI as mobench CLI
-    participant SDK as mobench-sdk
-    participant App as Generated mobile app
-    participant Device as Device or BrowserStack
-    participant Reports as Reports
-
-    Dev->>CLI: cargo mobench run
-    CLI->>SDK: resolve crate and benchmark spec
-    SDK->>SDK: build native libraries and generate bindings
-    SDK->>App: embed bench_spec.json and templates
-    CLI->>Device: install/upload and start run
-    Device->>App: execute benchmark function
-    App->>CLI: emit BenchReport JSON
-    CLI->>Reports: write summary.json, summary.md, results.csv
-```
-
-### BrowserStack CI lifecycle
-
-```mermaid
-flowchart TD
-    workflow["GitHub Actions"] --> resolve["Resolve device matrix"]
-    resolve --> build["Build APK or IPA/XCUITest"]
-    build --> upload["Upload artifacts to BrowserStack"]
-    upload --> run["Run benchmark on selected devices"]
-    run --> fetch["Fetch logs, reports, and metrics"]
-    fetch --> normalize["Normalize timing, CPU, and memory"]
-    normalize --> outputs["summary.json\nsummary.md\nresults.csv\nplots"]
-    outputs --> pr["Optional PR comment/check run"]
-```
-
-### Profiling artifact lifecycle
-
-```mermaid
-flowchart LR
-    run["profile run"] --> manifest["profile.json\nnative_capture\nsemantic_profile\ncapture_metadata"]
-    run --> raw["raw capture\nsimpleperf or sample"]
-    raw --> processed["processed stacks\nstacks.folded\nnative-report.txt"]
-    processed --> viewer["flamegraph.html\nfull and focused SVGs"]
-    manifest --> summary["summary.md"]
-    manifest --> semantic["artifacts/semantic/phases.json"]
-    viewer --> diff["profile diff\nbaseline vs candidate"]
-    summary --> diff
-```
-
-### SDK versus CLI responsibilities
-
-```mermaid
-flowchart TB
-    subgraph SDK["mobench-sdk"]
-        timing["timing harness"]
-        registry["benchmark registry"]
-        builders["Android/iOS builders"]
-        codegen["template/codegen"]
-        ffi["FFI-safe types"]
-    end
-
-    subgraph CLI["mobench CLI"]
-        config["config and project resolution"]
-        orchestration["build/run/profile orchestration"]
-        providers["BrowserStack and local providers"]
-        reporting["summary, plots, PR reports"]
-    end
-
-    SDK --> CLI
-    CLI --> SDK
-    user["Downstream benchmark crate"] --> SDK
-    ci["CI workflow"] --> CLI
-```
-
 ## Workspace crates
 
 - `crates/mobench` ([mobench](https://crates.io/crates/mobench)): CLI tool that builds, runs, and fetches benchmarks
@@ -299,6 +206,7 @@ min_sdk = 24
 [ios]
 bundle_id = "com.example.bench"
 deployment_target = "15.0"
+# runner = "swiftui"       # or "uikit-legacy" for legacy iOS deployment targets
 
 [benchmarks]
 default_function = "my_crate::my_benchmark"
@@ -310,6 +218,7 @@ Resolution precedence is: explicit CLI flags (`--project-root`, `--crate-path`)
 
 CLI flags override config file values when provided.
 - In `cargo mobench run --config <FILE>` mode, `--device-matrix <FILE>` overrides `device_matrix` from the config file.
+- iOS deployment targets below 15.0 use the UIKit legacy runner by default; forcing `runner = "swiftui"` below 15.0 fails early. Legacy targets such as iPhone 7 on iOS 10 also require an older Xcode lane capable of building for that OS.
 - For regression comparisons, `--baseline` should point to a previous run summary; if it resolves to the same output path, mobench snapshots the prior file before writing the candidate summary.
 - In the reusable GitHub workflow, the default baseline source is the latest successful run on the repository default branch when matching artifacts are available.
 - `cargo mobench verify --smoke-test` is only supported for benchmark crates linked into the `mobench` CLI binary. External crates discovered through `mobench.toml`, `--project-root`, or `--crate-path` should use `cargo mobench list` and `cargo mobench verify --check-artifacts`.
@@ -405,6 +314,99 @@ fn db_query(db: &Database) {
 | `#[benchmark(setup = fn, per_iteration)]` | Benchmarks that mutate input, need fresh data each time |
 | `#[benchmark(setup = fn, teardown = fn)]` | Resources requiring cleanup (connections, files, etc.) |
 
+## Workflow diagrams
+
+The Mermaid sources live under `docs/diagrams/` so the same diagrams can be
+reused in launch posts and landing-page assets.
+
+### Crate architecture
+
+```mermaid
+flowchart LR
+    user["Benchmark crate"] --> macro["mobench-macros\n#[benchmark]"]
+    macro --> registry["mobench-sdk registry\ninventory"]
+    registry --> runner["mobench-sdk runner\nBenchSpec -> BenchReport"]
+    runner --> templates["Generated Android/iOS runners"]
+    cli["mobench CLI"] --> builders["SDK builders"]
+    builders --> templates
+    cli --> reports["JSON / Markdown / CSV / plots"]
+    templates --> reports
+```
+
+### Benchmark lifecycle
+
+```mermaid
+sequenceDiagram
+    participant Dev as Developer
+    participant CLI as mobench CLI
+    participant SDK as mobench-sdk
+    participant App as Generated mobile app
+    participant Device as Device or BrowserStack
+    participant Reports as Reports
+
+    Dev->>CLI: cargo mobench run
+    CLI->>SDK: resolve crate and benchmark spec
+    SDK->>SDK: build native libraries and generate bindings
+    SDK->>App: embed bench_spec.json and templates
+    CLI->>Device: install/upload and start run
+    Device->>App: execute benchmark function
+    App->>CLI: emit BenchReport JSON
+    CLI->>Reports: write summary.json, summary.md, results.csv
+```
+
+### BrowserStack CI lifecycle
+
+```mermaid
+flowchart TD
+    workflow["GitHub Actions"] --> resolve["Resolve device matrix"]
+    resolve --> build["Build APK or IPA/XCUITest"]
+    build --> upload["Upload artifacts to BrowserStack"]
+    upload --> run["Run benchmark on selected devices"]
+    run --> fetch["Fetch logs, reports, and metrics"]
+    fetch --> normalize["Normalize timing, CPU, and memory"]
+    normalize --> outputs["summary.json\nsummary.md\nresults.csv\nplots"]
+    outputs --> pr["Optional PR comment/check run"]
+```
+
+### Profiling artifact lifecycle
+
+```mermaid
+flowchart LR
+    run["profile run"] --> manifest["profile.json\nnative_capture\nsemantic_profile\ncapture_metadata"]
+    run --> raw["raw capture\nsimpleperf or sample"]
+    raw --> processed["processed stacks\nstacks.folded\nnative-report.txt"]
+    processed --> viewer["flamegraph.html\nfull and focused SVGs"]
+    manifest --> summary["summary.md"]
+    manifest --> semantic["artifacts/semantic/phases.json"]
+    viewer --> diff["profile diff\nbaseline vs candidate"]
+    summary --> diff
+```
+
+### SDK versus CLI responsibilities
+
+```mermaid
+flowchart TB
+    subgraph SDK["mobench-sdk"]
+        timing["timing harness"]
+        registry["benchmark registry"]
+        builders["Android/iOS builders"]
+        codegen["template/codegen"]
+        ffi["FFI-safe types"]
+    end
+
+    subgraph CLI["mobench CLI"]
+        config["config and project resolution"]
+        orchestration["build/run/profile orchestration"]
+        providers["BrowserStack and local providers"]
+        reporting["summary, plots, PR reports"]
+    end
+
+    SDK --> CLI
+    CLI --> SDK
+    user["Downstream benchmark crate"] --> SDK
+    ci["CI workflow"] --> CLI
+```
+
 ## Release Notes
 
 Published release history and support status live in

crates/mobench-sdk/README.md

@@ -408,6 +408,7 @@ target_sdk = 34
 [ios]
 bundle_id = "com.example.bench"
 deployment_target = "15.0"
+# runner = "swiftui"       # or "uikit-legacy" for legacy iOS targets
 
 [benchmarks]
 default_function = "my_crate::my_benchmark"

crates/mobench-sdk/src/builders/common.rs

@@ -791,10 +791,21 @@ members = ["crates/*"]
         let _ = std::fs::remove_dir_all(&temp_dir);
         std::fs::create_dir_all(&temp_dir).unwrap();
 
-        let spec = EmbeddedBenchSpec {
+        #[derive(serde::Serialize)]
+        struct AndroidSpec {
+            function: String,
+            iterations: u32,
+            warmup: u32,
+            android_benchmark_timeout_secs: Option<u64>,
+            android_heartbeat_interval_secs: Option<u64>,
+        }
+
+        let spec = AndroidSpec {
             function: "test_crate::first_run".to_string(),
             iterations: 7,
             warmup: 1,
+            android_benchmark_timeout_secs: Some(30),
+            android_heartbeat_interval_secs: Some(5),
         };
 
         embed_bench_spec(&temp_dir, &spec).expect("embed spec");
@@ -812,6 +823,11 @@ members = ["crates/*"]
 
         let contents = std::fs::read_to_string(android_spec).unwrap();
         assert!(contents.contains("test_crate::first_run"));
+        assert!(contents.contains("android_benchmark_timeout_secs"));
+        assert!(contents.contains("android_heartbeat_interval_secs"));
+        let json: serde_json::Value = serde_json::from_str(&contents).unwrap();
+        assert_eq!(json["android_benchmark_timeout_secs"], 30);
+        assert_eq!(json["android_heartbeat_interval_secs"], 5);
 
         std::fs::remove_dir_all(&temp_dir).unwrap();
     }