feat: NucleusFonts#23
Merged
Merged
Conversation
jaidensiu
reviewed
May 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds font styling definitions to Nucleus. It's designed to be flexible so it can work with multiple font families as well as with a range of configuration options.
The definitions for fonts live in
tokens/definitions/font/fonts.json. This file should follow this format:{ "{{fontStyle}}": { "fontName": "WorldProMVP-LH", "size": 13, "weight": 325, "letterSpacing": 0.0, "lineHeight": 1.3, "dynamicTypeStyle": "caption2" }, "b1": { ... } }Check https://developer.apple.com/design/human-interface-guidelines/typography#iOS-iPadOS-Dynamic-Type-sizes to set the right value for the dynamicTypeStyle.
The build script has been split into multiple files to handle generation for color and font. This will make it easier to expand upon moving forward.
On both iOS and Android we have the concept of a NucleusFont object. This is a simple object that provides the font styling values. It's the clients responsibility to actually render the font depending on these definitions.