chore: Add HttpClient Type#12
Merged
Merged
Conversation
Takaros999
requested review from
andy-t-wang,
aurel-fr,
m1guelpf and
paolodamico
as code owners
andy-t-wang
previously approved these changes
Sep 8, 2025
andy-t-wang
reviewed
Sep 8, 2025
| pub const VSOCK_PROXY_CID: u32 = 3; | ||
|
|
||
| /// A HTTP client that tunnels all requests through the host's vsock proxy. | ||
| pub type HttpClient = Client<HttpsConnector<VSockClientBuilder>>; |
Contributor
There was a problem hiding this comment.
I think this might not work when you import in a project since VSockClientBuilder is private in utils.
Contributor
Author
There was a problem hiding this comment.
updated. It didn't cause compile issues, but it's an anti-pattern "private in public API" so I ended up re-exporting the type here.
andy-t-wang
approved these changes
Sep 8, 2025
| pub const VSOCK_PROXY_CID: u32 = 3; | ||
|
|
||
| /// A HTTP client that tunnels all requests through the host's vsock proxy. | ||
| pub type HttpClient = Client<HttpsConnector<VSockClientBuilder>>; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a type for the http client, previously it was improssible to use it because it was relying in a private
VSockClientBuildertype.