fix: exclude provekit deps from mobile builds via feature flags#386
Closed
agentotto[bot] wants to merge 1 commit into
Closed
fix: exclude provekit deps from mobile builds via feature flags#386agentotto[bot] wants to merge 1 commit into
agentotto[bot] wants to merge 1 commit into
Conversation
Contributor
|
this seems outdated now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
provekitfeature world-id-protocol#708provekit,zk-ownership-prove, orzk-ownership-verifyprovekitfeature towalletkit-coreandwalletkitfor platforms that want WIP-103 ownership proofsprovekitValidation
cargo tree -p walletkit --no-default-features --features storage,issuers --quiet | rg -c 'provekit[-_]|provekit_common'returns no actual ProveKit crate matchescargo tree -p walletkit --no-default-features --features storage,issuers,provekit --quiet | rg -c 'provekit[-_]|provekit_common'returns ProveKit crates when opted incargo check -p walletkit-core --no-default-features --features storage,issuerscargo check -p walletkit-core --no-default-features --features storage,issuers,provekitRelated
provekitfeature world-id-protocol#708provekitfeature world-id-protocol#708 is released, switch the temporary git dependency back to crates.io.