Skip to content

chore: slim down world-id-primitives deps#646

Open
paolodamico wants to merge 6 commits into
mainfrom
primitives-deps
Open

chore: slim down world-id-primitives deps#646
paolodamico wants to merge 6 commits into
mainfrom
primitives-deps

Conversation

@paolodamico
Copy link
Copy Markdown
Collaborator

@paolodamico paolodamico commented Apr 10, 2026

Feature flags proof dependencies in the primitives crate to reduce the amount of dependencies pulled in upstream crates.


Note

Medium Risk
Medium risk due to API signature changes in world-id-primitives (error type switch to PrimitiveError) and new feature-flagged compilation paths that could break downstream builds if features are misconfigured.

Overview
Slims world-id-primitives dependency surface by introducing a proofs feature that gates Groth16/circuit-input related code and dependencies (including circuit_inputs and ZeroKnowledgeProof::from_groth16_proof). Downstream crates that need proof generation (authenticator, proof, oprf-node, oprf-dev-client) now enable world-id-primitives with features = ["proofs"].

Modernizes signing deps and error handling by switching request signatures and the internal Signer to use alloy-signer/alloy-signer-local instead of alloy re-exports, and by changing Credential::{claims_hash,hash,sign,verify_signature} to return PrimitiveError (with callers updated accordingly). Minor doc-link cleanup in authenticator docs accompanies the refactor.

Reviewed by Cursor Bugbot for commit fa83c4d. Bugbot is set up for automated code reviews on this repo. Configure here.

@paolodamico
Copy link
Copy Markdown
Collaborator Author

@codex review

Comment thread crates/primitives/src/session.rs Outdated
Copy link
Copy Markdown
Contributor

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 778e67a. Configure here.

Comment thread crates/proof/Cargo.toml Outdated
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7024e36c26

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread crates/authenticator/Cargo.toml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant