chore: slim down world-id-primitives deps#646
Open
paolodamico wants to merge 6 commits into
Open
Conversation
Collaborator
Author
|
@codex review |
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 778e67a. Configure here.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7024e36c26
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Feature flags proof dependencies in the primitives crate to reduce the amount of dependencies pulled in upstream crates.
Note
Medium Risk
Medium risk due to API signature changes in
world-id-primitives(error type switch toPrimitiveError) and new feature-flagged compilation paths that could break downstream builds if features are misconfigured.Overview
Slims
world-id-primitivesdependency surface by introducing aproofsfeature that gates Groth16/circuit-input related code and dependencies (includingcircuit_inputsandZeroKnowledgeProof::from_groth16_proof). Downstream crates that need proof generation (authenticator,proof,oprf-node,oprf-dev-client) now enableworld-id-primitiveswithfeatures = ["proofs"].Modernizes signing deps and error handling by switching request signatures and the internal
Signerto usealloy-signer/alloy-signer-localinstead ofalloyre-exports, and by changingCredential::{claims_hash,hash,sign,verify_signature}to returnPrimitiveError(with callers updated accordingly). Minor doc-link cleanup in authenticator docs accompanies the refactor.Reviewed by Cursor Bugbot for commit fa83c4d. Bugbot is set up for automated code reviews on this repo. Configure here.