Skip to content

chore: explicit oprf-node release#726

Open
paolodamico wants to merge 4 commits into
mainfrom
pdc/oprf-node-release-plz
Open

chore: explicit oprf-node release#726
paolodamico wants to merge 4 commits into
mainfrom
pdc/oprf-node-release-plz

Conversation

@paolodamico
Copy link
Copy Markdown
Collaborator

@paolodamico paolodamico commented May 12, 2026

Introduces an explicit workflow to generate and publish releases to the oprf-node images, instead of building on every push to main.


Note

Medium Risk
Moderate risk because it changes CI/CD behavior for oprf-node, including tagging/releases and container publishing conditions, which could impact delivery if misconfigured.

Overview
Stops building/publishing the oprf-node image as part of the generic build-docker matrix, leaving only indexer and gateway there.

Adds two GitHub Actions workflows for oprf-node: a manual Prepare OPRF Node Release workflow that opens a release-plz release PR, and an on-main Publish OPRF Node Release workflow that detects a services/oprf-node/Cargo.toml version bump, creates the GitHub release/tag, and then builds/attests and pushes ghcr.io/.../world-id-oprf-node with latest and version tags.

Bumps world-id-oprf-node from 0.1.0 to 0.2.0 (workspace + lockfile), marks the crate publish = false, and introduces services/oprf-node release metadata/docs (release-plz.toml, CHANGELOG.md, README.md).

Reviewed by Cursor Bugbot for commit ada9887. Bugbot is set up for automated code reviews on this repo. Configure here.

@paolodamico paolodamico marked this pull request as ready for review May 12, 2026 20:45
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 79b5f135e7

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .github/workflows/release-oprf-node.yml
Comment thread services/oprf-node/release-plz.toml Outdated
Comment thread services/oprf-node/Cargo.toml
Copy link
Copy Markdown
Contributor

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit ada9887. Configure here.

exit 0
fi

before_version="$(git show "$BEFORE_SHA:services/oprf-node/Cargo.toml" 2>/dev/null | sed -n 's/^version = "\(.*\)"/\1/p' | head -n1)"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pipefail causes script exit on unreachable BEFORE_SHA

Low Severity

With set -euo pipefail, if git show fails (e.g., BEFORE_SHA is unreachable after a force push or is the null SHA), the pipeline's exit status propagates as non-zero due to pipefail. Since before_version="$(failing_pipeline)" is a simple variable assignment, set -e causes the script to exit immediately rather than continuing to the [ -z "$before_version" ] check that was clearly designed to handle this case gracefully. The 2>/dev/null only suppresses stderr, not the exit code.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit ada9887. Configure here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants