chore: Use old poseidon wrapper for tree operations on v1 registry#767
Open
Kemperino wants to merge 4 commits into
Open
chore: Use old poseidon wrapper for tree operations on v1 registry#767Kemperino wants to merge 4 commits into
Kemperino wants to merge 4 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
contract size: 21,242
Note
Medium Risk
Changes how Merkle roots are computed on V1 write paths; a mismatch with deployed behavior would break proof validity, though the intent is bytecode-level compatibility with the original public Poseidon call pattern.
Overview
Splits V1 registry Merkle writes from the shared
FullStorageBinaryIMThelpers so they always hash through a V1-style publicPoseidon2T2V1library call, matching how the original registry built roots.WorldIDRegistrynow routes insert/update/batch insert via virtual_insertLeaf,_insertManyLeaves, and_updateLeafAndRecordthat delegate to newWorldIDRegistryV1Tree(logic copied from the IMT library, usingPoseidon2T2V1).FullStorageBinaryIMTwidens_key/_getNodetointernalso that library can reuse node lookups.WorldIDRegistryV2overrides those hooks to keep usingFullStorageBinaryIMTwith the current internalPoseidon2T2path for post-upgrade behavior.Reviewed by Cursor Bugbot for commit 9339ab4. Configure here.