Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summery :
This PR adds a new CLI command check-public-inputs that verifies the public inputs stored in a proof file (proof.np/proof.json) match the witness values from the original Noir circuit execution. This enables users to detect if public inputs have been tampered with by an attacker.
Motivation
When a proof is generated, the public_inputs are stored in the proof file:
This tool allows verification that the public inputs in a proof match what would be computed from the original circuit and inputs.
How It Works :
circuit.json(from nargo compile) to extract public input witness indices from public_parameters and return_values in the ACIR bytecode.Soundness : The soundness comes from Noir's deterministic witness solving. Given the same circuit and inputs, nargo execute always produces the same witness vector in a fixed order. By sorting public inputs by their ACIR witness index, we establish a canonical ordering that matches how the prover stores them.
Summary of Changes :