feat: CE-5201: Add FilterSiteInput to device and device summary filters#184
Merged
Jackson Allen (jackson-allen-worlds) merged 1 commit intoMay 15, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR extends the GraphQL API contract and generated Java SDK models so device and device-summary filters can target nested site attributes via FilterSiteInput.
Changes:
- Adds
site: FilterSiteInputtoFilterDeviceInput. - Adds
site: FilterSiteInputtoFilterDeviceSummaryInput. - Updates generated Java input models, builders, equality, and hash code handling for the new fields.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
graphql/api/domains/devices/filter.graphqls |
Adds nested site filtering to device filters. |
graphql/api/domains/summary/filter.graphqls |
Adds nested site filtering to device summary filters. |
java/src/main/java/io/worlds/api/model/FilterDeviceInput.java |
Updates generated Java model for the new device site filter. |
java/src/main/java/io/worlds/api/model/FilterDeviceSummaryInput.java |
Updates generated Java model for the new device summary site filter. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Stephen Niles (sniles)
approved these changes
May 15, 2026
Jackson Allen (jackson-allen-worlds)
deleted the
CE-5201-be-filter-devices-by-site
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
site: FilterSiteInputfield onFilterDeviceInputandFilterDeviceSummaryInputso clients can filter devices and device summaries by site attributes (not just site ID).Test plan
sitefilter and verify expected resultsCE-5201