fix: handle Infinity/NaN in Power evaluation (Von autonomous AI patch) - #2
Open
wowo515151 wants to merge 1 commit into
Open
fix: handle Infinity/NaN in Power evaluation (Von autonomous AI patch)#2wowo515151 wants to merge 1 commit into
wowo515151 wants to merge 1 commit into
Conversation
…ption Previously, when Math.Pow() produced Infinity or NaN, the guard check called SafeToDecimal() which itself throws. Now it throws OverflowException directly, caught by the existing catch block for proper handling. Fixes #1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a critical bug in
NumericEvaluator.EvaluateRecursive()where the Power evaluation guard check for Infinity/NaN results was self-defeating — it detected the problematic condition but then calledSafeToDecimal()on the offending value, which itself throws an exception.The Bug
File:
src/SymSolvers/NumericEvaluator.cs(line 308-310)When
Math.Pow()producedInfinityorNaN, the code did:SafeToDecimal()(insrc/SymCore/NumericConvert.cs) explicitly throws:InvalidOperationExceptionfor NaN valuesOverflowExceptionfor Infinity valuesThe Fix
Replace the problematic
return SafeToDecimal(resPow)withthrow new OverflowException(...), which is properly caught by the existingcatchblock below that handles overflow gracefully:The existing catch block then:
Impact
TryEvaluate()error-handling contract — exceptions no longer leak unhandled0^(-2),(-1)^0.5, and very largebase^exponentFiles Changed
src/SymSolvers/NumericEvaluator.cs— 1 line changed (guard throw instead of SafeToDecimal call)Testing
GitHub Actions CI will run the full test suite including
SymSolvers.Testswhich coversNumericEvaluator.Fixes #1