UR-4225 Fix - Triage snyk vulnerability report findings#1188
Merged
MILAN88888 merged 7 commits intodevelopfrom Apr 30, 2026
Merged
UR-4225 Fix - Triage snyk vulnerability report findings#1188MILAN88888 merged 7 commits intodevelopfrom
MILAN88888 merged 7 commits intodevelopfrom
Conversation
Keep XSS-safe versions ($.parseHTML, .text(), wp_kses_post, esc_attr, sanitize_text_field) over develop's unescaped equivalents across all conflict files. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
This PR fixes several security issues, including nonce handling, escaping, and sanitization improvements. Some medium-severity issues remain, but they can be safely ignored because they occur in the frontend JavaScript and the data involved is already sanitized on the backend.
For future JavaScript implementations, we should follow a detached DOM structure when appending HTML to ensure safer and more maintainable code.
`// ❌ BAD — appends to live DOM 100 times = 100 repaints $(plans).each(function(k, item) { urmg_container.append('
// ✅ GOOD — build everything in memory first, ONE append = ONE repaint var$wrapper = $ ('
'); // detached, in memory $(plans).each(function(k, item) { $wrapper.append($card); // no repaint, just memory operation }); urmg_container.append($wrapper); // ONE repaint at the end ✅`[
snyk-report.html
](url)
How to test the changes in this Pull Request:
Types of changes:
Other information:
Changelog entry