test: smoke-test-career — full 3-season engine end-to-end - #19
Open
wpinrui wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scripts/smoke-test-career.ts: a standalone Node.js script that drives a full 3-season career through the real Zustand store with no UIlocalStorageso thepersistmiddleware doesn't block execution in NodesimulateAIShotfor the player's shots (testing the pipeline, not player skill)What is tested
startCareer: roster = 50, country codes unique, shakiness/age/phase correct
Per-event (15 events total):
Per-season (3 seasons):
retire: 5 highlight slides max, last is championship; career history = 3 rows; phase = 'retired'
resetCareer: state fully wiped back to initial values
Bug discovered during development
The script initially pre-computed the "retiring 5" from the un-aged roster. But
completeSeasonages all competitors first, then retires the bottom 5 of the aged roster — which can be a different set. Fixed by replicating the aging step viaageCompetitorbefore identifying which codes will be replaced.Also
Opened issue #18 for pre-existing
yarn linterrors inShootingHUD(found during this task, pre-date this PR).Usage