Rubocop

[Marthyn]

Since at Hoppinger we use rubocop now, i decided while reading the code to fix some issues. I was a little lenient wit AbcSize and Methodlength

[sebastiaandegeus]

You used a very different rubocop ruleset than we use in other Hoppinger projects. For instance you changed all quotations to double quotes while the latest default rubocop ruleset uses single quotes simple strings.

[sebastiaandegeus]

Also in the readme single quotes have been changed where it should be a single code. It is not guaranteed that all WP"s processing is complete (some actions may still fire) by the time the webhook call is made.

[sebastiaandegeus]

@Marthyn Please add this to your personal global .gitignore file.

[Marthyn]

I thought I got the rubocop file from the dotfiles repo, but I'll check again

Sent from my iPhone

On Wed, Jun 10, 2015 at 8:16 AM -0700, "Sebastiaan" notifications@github.com wrote:
You used a very different rubocop ruleset than we use in other Hoppinger projects. For instance you changed all quotations to double quotes while the latest default rubocop ruleset uses single quotes simple strings.

---

Reply to this email directly or view it on GitHub:
#38 (comment)

[sebastiaandegeus]

@Marthyn Here single quotes are actually valid. Regardless of the rubocop setting. Did rubocop report this as wrong inside a .md file?

[Marthyn]

I should run rubocop only on lib and app folders probably

Sent from my iPhone

On Wed, Jun 10, 2015 at 8:22 AM -0700, "Sebastiaan" notifications@github.com wrote:

@@ -10,7 +10,7 @@ This library is part of the WP on Rails proj

To prepare a WP installation to be used in a WP on Rails architecture the wp-relinquish plugin is provided. It provides a means to configure WP actions to send notifications as webhook calls to a Rails application equipped with wp-connector.

-When using WP on Rails the content's master data resides in WP's database, as that's where is it created and modified. The Rails application that is connected to WP stores merely a copy of the data, a cache, on the basis of which the public requests are served.
+When using WP on Rails the content"s master data resides in WP"s database, as that"s where is it created and modified. The Rails application that is connected to WP stores merely a copy of the data, a cache, on the basis of which the public requests are served.

@Marthyn Here single quotes are actually valid. Regardless of the rubocop setting. Did rubocop report this as wrong inside a .md file?

---

Reply to this email directly or view it on GitHub:
https://github.com/wponrails/wp-connector/pull/38/files#r32129172

[Marthyn]

I rebased out the non lib/app files.

[dunyakirkali]

👍