Skip to content

Always cancel read cell on write path #275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
akiradeveloper merged 1 commit into from
Jul 10, 2025
+4 −5
Merged

Always cancel read cell on write path #275

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions src/dm-writeboost-target.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1180,7 +1180,6 @@ static int do_process_write(struct wb_device *wb, struct bio *bio)
mutex_lock(&wb->io_lock);

cache_lookup(wb, bio, &res);
Comment on lines 1181 to 1182

Copilot AI Jul 10, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] There appears to be an unnecessary blank line removal after cache_lookup. This formatting change is unrelated to the core logic change and could be kept for better code readability.

Suggested change
cache_lookup(wb, bio, &res);
cache_lookup(wb, bio, &res);

Copilot uses AI. Check for mistakes.

if (res.found) {
if (unlikely(res.on_buffer)) {
write_pos = res.found_mb;
Expand All @@ -1191,8 +1190,8 @@ static int do_process_write(struct wb_device *wb, struct bio *bio)
if (err)
goto out;
}
} else
might_cancel_read_cache_cell(wb, bio);
}
might_cancel_read_cache_cell(wb, bio);

might_queue_current_buffer(wb);

Expand Down Expand Up @@ -1280,8 +1279,8 @@ static int process_write_wa(struct wb_device *wb, struct bio *bio)
if (res.found) {
dec_inflight_ios(wb, res.found_seg);
ht_del(wb, res.found_mb);
} else
might_cancel_read_cache_cell(wb, bio);
}
might_cancel_read_cache_cell(wb, bio);
mutex_unlock(&wb->io_lock);

bio_remap(bio, wb->backing_dev, bi_sector(bio));
Expand Down