Skip to content

refactor: Use shared Cerebro Go API SDK#159

Merged
jonathanhaaswriter merged 4 commits into
mainfrom
droid/use-cerebro-go-sdk-20260617
Jun 17, 2026
Merged

refactor: Use shared Cerebro Go API SDK#159
jonathanhaaswriter merged 4 commits into
mainfrom
droid/use-cerebro-go-sdk-20260617

Conversation

@jonathanhaaswriter

Copy link
Copy Markdown
Contributor

Summary

Migrates Aperio's Cerebro integration to the shared Go SDK from writer/cerebro.

  • Replaces the local Cerebro HTTP client implementation with a thin wrapper around github.com/writer/cerebro/sdk/go/cerebroapi.
  • Reuses the shared Cerebro claim/URN helpers for claim construction.
  • Keeps Aperio-specific defaults for runtime/source IDs and user agent.

Depends on: writer/cerebro#1139

Test Plan

  • make test-go
  • make lint

@github-actions

github-actions Bot commented Jun 17, 2026

Copy link
Copy Markdown

Droid finished @jonathanhaaswriter's task —— View job


Security Review

I validated all candidate review comments and there were none to approve for posting. I did not identify a clear, high-confidence issue that warrants an inline review comment on this PR.

@github-actions

github-actions Bot commented Jun 17, 2026

Copy link
Copy Markdown

Droid finished @jonathanhaaswriter's task —— View job


Security Review


The refactor cleanly replaces the local Cerebro HTTP implementation with the shared SDK and is well-structured overall. One data-integrity concern stands out: delegating EncodeExternalID to the SDK changes how spaces are encoded in URNs (from - to %20), which will silently orphan any Cerebro entities whose external IDs contained spaces, creating duplicates on re-ingestion. Additionally, the explicit HTTP redirect-blocking that guarded against SSRF via 3xx responses has been removed and should be confirmed present in the SDK.

Comment thread internal/cerebroclaims/builder.go Outdated
Comment thread internal/cerebroclient/client.go
@github-actions

github-actions Bot commented Jun 17, 2026

Copy link
Copy Markdown

Droid finished @jonathanhaaswriter's task —— View job


Security Review

Validated all candidate review comments for PR #159. I did not approve any new inline comments. The current head preserves Aperio's external ID encoding behavior, and the shared Cerebro SDK retains redirect blocking, so I did not find a new high-confidence issue to post.

@github-actions

github-actions Bot commented Jun 17, 2026

Copy link
Copy Markdown

Droid finished @jonathanhaaswriter's task —— View job


Security Review

Validated all candidates and approved none for posting. On the current head, Aperio still preserves its local external-ID URN encoding and the shared Cerebro SDK still blocks redirects, so I did not find a high-confidence inline issue to post.

@jonathanhaaswriter jonathanhaaswriter merged commit d289a51 into main Jun 17, 2026
15 checks passed
@jonathanhaaswriter jonathanhaaswriter deleted the droid/use-cerebro-go-sdk-20260617 branch June 17, 2026 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant