fix(test): stabilize graph intelligence windows and regenerate config docs#191
Open
jonathanhaaswriter wants to merge 6 commits intomainfrom
Open
fix(test): stabilize graph intelligence windows and regenerate config docs#191jonathanhaaswriter wants to merge 6 commits intomainfrom
jonathanhaaswriter wants to merge 6 commits intomainfrom
Conversation
… docs Use time.Now()-relative dates in agent-action-effectiveness, playbook- effectiveness, and unified-execution-timeline endpoint tests so they remain valid regardless of when CI runs. Regenerate CONFIG_ENV_VARS.md to reflect the additional empty-string default for AWS_REGION.
The security-source-scan workflow was passing all shard packages to gosec in a single invocation, causing consistent 15-minute timeouts. Align with the CI workflow pattern of scanning packages one-by-one, merging JSON reports afterward. Bump timeout to 20 minutes for headroom.
# Conflicts: # internal/graph/vendor_risk_test.go
josh-writer
requested changes
Apr 14, 2026
| for path in sorted(glob.glob('${tmp_dir}/report-*.json')): | ||
| with open(path) as f: | ||
| data = json.load(f) | ||
| merged.extend(data.get('Issues') or []) |
Collaborator
There was a problem hiding this comment.
The new merge step only carries forward Issues from each per-package JSON report and rewrites the shard artifact as {"Issues": [...]}. gosec also emits analyzer/build failures under Golang errors (for example on parser/type-check problems), so if one package cannot be analyzed, that signal is now discarded and the shard can appear clean with no indication coverage was incomplete. The previous single-report flow at least preserved those errors in the uploaded artifact. I’d recommend aggregating Golang errors as well, and ideally failing or at least surfacing them in the summary step.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
CI on main is failing with two issues:
Test shard 0 failures:
TestGraphIntelligenceAgentActionEffectivenessEndpointandTestGraphIntelligenceUnifiedExecutionTimelineEndpointuse hardcoded March 2026 dates for test fixtures, but the handlers call report builders without settingNow, causingtime.Now()to be used internally. As real time advances past those fixture dates + the trend/window period, the data falls outside the query window and tests fail.config-docs-drift:
docs/CONFIG_ENV_VARS.mdwas not regenerated afterAWS_REGIONgained an additional empty-string default from the OpenSearch region config field.Fix
time.Date()values withtime.Now().UTC()-relative offsets in three tests: agent-action-effectiveness, playbook-effectiveness, and unified-execution-timeline.CONFIG_ENV_VARS.mdviamake config-docs.