chore(audio): migrate stable fingerprints to sha2 0.11 - #272
Conversation
Encode each SHA-256 digest byte as two lowercase hex characters and pin leading-zero compatibility. Regenerate Flatpak sources for sha2 0.11. Co-Authored-By: Codex gpt-6-astra <noreply@openai.com>
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
Merge the reviewed Symphonia predecessor fixes into the sha2 successor, retaining tolerant EOF decoding and ALAC support. Co-Authored-By: Codex gpt-6-astra <noreply@openai.com>
|
This was written agentically; verify its assertions: Adversarial review receipt
🤖 Co-authored by Codex gpt-6-astra. |
|
This was written agentically; verify its assertions: Review ledgerMachine-readable record of every review already performed on this PR. {
"version": 1,
"pr": 272,
"repo": "wrzonance/HonkHonk",
"reviews": [
{
"kind": "adversarial",
"provider": "anthropic",
"model": "claude-fable-5-1",
"effort": "xhigh",
"mode": "cross-provider",
"attemptId": "38fecddf-cfa1-4a1c-88b3-9e48d3fd889b",
"launcherSha256": "4d1fc623db1b387d5d6dc0792b56ea5fcc25bf1297a77b9aca4dab243902bd50",
"procedure": "one-shot diff review; no contract-blind or two-pass attestation",
"reviewerOverride": "",
"harness": "codex",
"head_sha": "bc7a0d09ddf0795e2a9ec771cb2675320e5a575e",
"covered_heads": [
"bc7a0d09ddf0795e2a9ec771cb2675320e5a575e"
],
"diff_payload": "wrzonance/HonkHonk:272:11f88a922a4781be7992446a86133fb8cc1a49b5eb00253ec6b7f7f678978d8a",
"findings": [],
"counts": {
"p1": 0,
"p2": 0
},
"reviewed_at": "2026-09-16T04:51:11Z"
}
]
}🤖 Co-authored by Codex gpt-6-astra. |
Co-Authored-By: Codex <noreply@openai.com>
Co-Authored-By: Codex <noreply@openai.com>
This was written agentically; verify its assertions:
Why
Sha2 0.11 returns a digest without LowerHex support, so a dependency-only bump fails to compile. Content fingerprints are persisted and must remain byte-identical across this upgrade.
What
Encode each SHA-256 byte as two lowercase hexadecimal digits and pin the persisted identity with a fixed-input regression covering leading and full zero bytes. Upgrade sha2 to 0.11, regenerate Flatpak Cargo sources, and remove the obsolete Renovate version hold. Existing Iced dependencies retain sha2 0.10 transitively; no new direct dependency was added.
Testing
The prior one-shot adversarial review had no findings; its receipt remains in the PR comments. Coverage was not measured locally because cargo-tarpaulin is unavailable.
Closes #266
🤖 Co-authored by Codex.