fix(parallel-issues): name the selection helper by its shipped path - #891
Merged
Merged
Conversation
v0.9.12 is tagged at the current trunk, so shipped bytes cannot change until the manifests name the next patch. Mirrors the last bump (d270645): the three source manifests, the OpenCode lockfile, and a plugin rebuild. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
A Codex root on 0.9.12 met bare `pick-issues.sh` in Step 2b, guessed `$agentkit/parallel-issues/scripts/`, searched with rg (which skips the hidden `.shared/`), reported the helper missing, and ended the run (#889): one wasted root turn and one human round trip for a helper that ships. Step 2b now spells `$agentkit/.shared/scripts/pick-issues.sh` where the section first names it, and `degraded=yes` needs `ls -l` output on that path plus the failure text, never a guessed path. The skill body stays under its previous estimated-token count. `triage-issues.sh --help` ends with the next command so the path reaches the root as tool output. `lint-helper-refs.sh` now holds mention order per heading section: a shared or cross-skill helper named bare before its path in the same section is a violation; a skill's own scripts/ helpers are exempt because the natural guess lands there. The gate fails on origin/main at parallel-issues:248 and onboard-repo:250; both are fixed here at zero body growth. The helper tree ceiling moves to the exact new measurement. Closes #889 Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was written agentically; verify its assertions:
Why
A Codex root running parallel-issues 0.9.12 read bare
pick-issues.shin Step 2b, guessed$agentkit/parallel-issues/scripts/, searched withrg --files(which skips the hidden.shared/), reported the shipped helper missing, and ended the run. That cost one wasted root turn and one human round trip with zero dispatches (#889); this change removes both.What
parallel-issues/SKILL.mdnames the helper by its shipped path where the section first mentions it, anddegraded=yesnow requiresls -l "$agentkit/.shared/scripts/pick-issues.sh"output plus the failure text, never a guessed path. Wording in the same paragraph was trimmed so the body's estimated tokens fell (66,146 → 66,142 bytes; 16,536 → 16,535 est. tokens). The[parallel-issues]ceiling is untouched.triage-issues.sh --helpends its recipe with the next command,"$agentkit/.shared/scripts/pick-issues.sh" --help, so the path reaches the root as tool output. Line count unchanged (576); the helper tree ceiling moves to the exact new measurement (477,429 → 477,442).tests/lint-helper-refs.shholds mention order per heading section: a shared or cross-skill helper named bare before its path in the same section is a violation. A skill's ownscripts/helpers are exempt because the natural guess lands there; a heading-shaped shell comment inside a fence is not a section break. On origin/main (147cd00) the gate fails atparallel-issues/SKILL.md:248andonboard-repo/SKILL.md:250; both are fixed here with zero body growth (onboard-repo 21,036 → 21,032 bytes). Three fixture cases pin the rule intests/test-helper-refs.sh.Testing
tests/run-tests.shgreen (ALL GREEN, 141 suites, 0 failures, ~2m29s)shellcheck -x -P SCRIPTDIR -S styleclean on all five changed shell files🤖 Co-authored by Claude Fable 5.1. Closes #889.
🤖 Generated with Claude Code