Repository navigation
fix(commit): reject SHA-256 signatures and non-UTF-8 messages - #36
Merged
wsehl merged 1 commit intoSep 29, 2026
Conversation
The signed-commit check only matched the `gpgsig` header, so commits signed in SHA-256 repositories (`gpgsig-sha256`) were rewritten with a signature that no longer verifies. Commit objects are read as UTF-8, so a message stored in another `encoding` would be corrupted on rewrite and in the PR text. Such commits are now rejected with a clear error instead. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> bstack-id: feee043856314f52a15d170ea27e9381
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The signed-commit check only matched the
gpgsigheader, so commitssigned in SHA-256 repositories (
gpgsig-sha256) were rewritten with asignature that no longer verifies.
Commit objects are read as UTF-8, so a message stored in another
encodingwould be corrupted on rewrite and in the PR text. Suchcommits are now rejected with a clear error instead.
🤖 Generated with Claude Code
Co-Authored-By: Claude Opus 5.5 (1M context) noreply@anthropic.com