ci: turn the nightly e2e schedule off until #429 is fixed - #449
Merged
Merged
Conversation
Tracked by #448, which exists so this does not quietly stay off. Two nights, two red runs, both on #429 -- a known and triaged bug in `restart --supervisor`. A nightly that is EXPECTED to be red is a nightly nobody reads, and the next real regression would have arrived as one more red run in a row of them. That is worse than no nightly, because it looks like coverage. workflow_dispatch is untouched, and RELEASING.md still requires a run on the release commit -- which is the moment it has to be true. Worth recording that it earned its keep before being switched off. In three runs it found #444 (install failing on a profile with no Run key, which no unit test could catch because the test helper created the key the product assumed), the audit flag-parsing bug in #428 within 45 seconds of its first run, and #429 itself. The alternative was skipping the one stage with a link to #429. I did not take it: this release spent a lot of effort removing exactly that pattern, and a skipped stage hides a real bug where a disabled schedule with a tracking issue does not.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracked by #448, which exists so this does not quietly stay off.
Two nights, two red runs, both on #429 — a known and triaged bug in
restart --supervisor. A nightly that is expected to be red is a nightly nobody reads, and the next real regression would have arrived as one more red run in a row of them. Worse than no nightly, because it looks like coverage.workflow_dispatchis untouched, andRELEASING.mdstill requires a run on the release commit.It earned its keep first
In three runs it found:
installfailing on a profile with noRunkey. No unit test could catch it: the test helper created the key the product assumed existed.skrog auditflag-parsing bug, within 45 seconds of its first run.Why not just skip the one stage
That was the alternative, and I did not take it. This release spent a lot of effort removing exactly that pattern — a skipped stage hides a real bug, where a disabled schedule with a tracking issue does not.