Provide execute permissions to docker-entrypoint.sh#465
Open
sahandilshan wants to merge 1 commit intowso2:masterfrom
Open
Provide execute permissions to docker-entrypoint.sh#465sahandilshan wants to merge 1 commit intowso2:masterfrom
sahandilshan wants to merge 1 commit intowso2:masterfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR ensures the entrypoint script is executable before container start to address a permission error.
- Added a
chmod +xcommand for thedocker-entrypoint.shfile. - Updated the entrypoint definition remains unchanged but now relies on explicit permissions.
| EXPOSE 4000 9763 9443 | ||
|
|
||
| # Provide execute permissions to docker-entrypoint.sh | ||
| RUN chmod +x /home/wso2carbon/docker-entrypoint.sh |
There was a problem hiding this comment.
[nitpick] Use the WORKING_DIRECTORY environment variable instead of hardcoding the path to improve consistency, e.g., RUN chmod +x ${WORKING_DIRECTORY}/docker-entrypoint.sh.
Suggested change
| RUN chmod +x /home/wso2carbon/docker-entrypoint.sh | |
| RUN chmod +x ${WORKING_DIRECTORY}/docker-entrypoint.sh |
Comment on lines
+134
to
+135
| RUN chmod +x /home/wso2carbon/docker-entrypoint.sh | ||
|
|
There was a problem hiding this comment.
Consider setting execute permissions during the COPY step using --chmod=+x (Docker 18.09+) to reduce image layers, e.g., COPY --chmod=+x docker-entrypoint.sh ${WORKING_DIRECTORY}/.
Suggested change
| RUN chmod +x /home/wso2carbon/docker-entrypoint.sh |
AnuradhaSK
approved these changes
Jul 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Fix #463