Skip to content

Make Rails-8 compatible#1

Merged
sku-wtag merged 5 commits intomasterfrom
Make-Rails-8-compatible
Nov 30, 2025
Merged

Make Rails-8 compatible#1
sku-wtag merged 5 commits intomasterfrom
Make-Rails-8-compatible

Conversation

@sku-wtag
Copy link
Copy Markdown
Collaborator

@sku-wtag sku-wtag commented Nov 16, 2025 •
edited
Loading

Upgraded this gem to make compatible with Rails-8

sku-wtag
sku-wtag commented Nov 24, 2025
View reviewed changes
Comment thread lib/rest_in_peace/api_call.rb

def get
response = api.get(url, params)
response = api.get(url, **params)
Copy link
Copy Markdown
Collaborator Author

@sku-wtag sku-wtag Nov 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Refer to: https://www.ruby-lang.org/en/news/2019/12/12/separation-of-positional-and-keyword-arguments-in-ruby-3-0/

cht-wtag
cht-wtag approved these changes Nov 25, 2025
View reviewed changes
Copy link
Copy Markdown

@cht-wtag cht-wtag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved as a security reviewer

@sku-wtag sku-wtag merged commit 474aa68 into master Nov 30, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tor-wtag tor-wtag tor-wtag approved these changes

@cht-wtag cht-wtag cht-wtag approved these changes

Assignees

No one assigned

Labels

security_review_done

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sku-wtag @tor-wtag @cht-wtag