Installable Themes#2
Open
sam-mi wants to merge 11 commits into
Open
Conversation
added 11 commits
February 2, 2018 16:22
remove import theming from setup.py and set the version manually to allow this package to be pip installed into an empty repo via requirements.txt when installed at the same time as Django - removes ModuleNotFoundError on pip install
This change adds a method `get_theming_root` to `Theme` and calls that passing the theming root if necessary. It returns either a list of full paths to themes within virtual environments (allowing them to be used) or a single full path if `theme_slug` is passed in. Update docs to explain usage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request primarily allows for installable themes to be used with django-template-theming, themes can be defined in a dict by their slug and app_label and then this change will use the full path of the installed app to find the them root.
It also fixes a few minor issues: