Merged
Conversation
twiss
reviewed
Sep 8, 2025
draft-wussler-openpgp-forwarding.md
Outdated
Comment on lines
271
to
272
| If the key ID is set to all zeros for "anonymous recipient", see {{I-D.ietf-openpgp-crypto-refresh}} | ||
| Section 5.1.8, the proxy MAY transform all PKESKs in a message that it is |
Collaborator
There was a problem hiding this comment.
This text is accurate for PKESKv4 (which is what we use for now), but looking forward to PKESKv6, it omits the fingerprint entirely (originally with a version octet of 0, hence this text, now with a length octect of 0); so maybe we should just say something like
Suggested change
| If the key ID is set to all zeros for "anonymous recipient", see {{I-D.ietf-openpgp-crypto-refresh}} | |
| Section 5.1.8, the proxy MAY transform all PKESKs in a message that it is | |
| If the PKESK indicates an "anonymous recipient" (see {{I-D.ietf-openpgp-crypto-refresh}} | |
| Section 5.1.8), the proxy MAY transform all PKESKs in a message that it is |
(and separately / later on we should replace {{I-D.ietf-openpgp-crypto-refresh}} with {{RFC9580}} everywhere ^.^)
Contributor
Author
There was a problem hiding this comment.
I'm of course happy to see the text generalized - your suggestions is great. I've updated this PR to reflect it.
wussler
approved these changes
Sep 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.