link with libXrdPfc instead of libXrdFileCache for Xrootd-5#1
Open
ddavila0 wants to merge 1 commit into
Open
Conversation
|
@wyang007 we need this change to get the XRootD 5 RC1 into Ilija's hands for his ATLAS XCaches |
Owner
|
@ddavila0 @brianhlin , Many thanks for the update. Can you re-send the pull request to https://github.com/xrootd/rucioN2N-for-Xcache. I moved the repo to from my personal github account to the xrootd org. account. Right now they are identical. Also can OSG build the rpm from there in the future? |
Owner
|
Hi Brian, Diego,
Looking at this again, I realize that the reason I linked again libXrdFileCache was because of the need from previous code that is no long in use. And in fact I think we don’t actually need to link against libXrdFileCache. I tested in my 4.11.2 setup.
My guess we also don’t need to link again libXrdPfc in order to be compatible to Xrootd 5. Do this think this is the case for your testing environment.
regards,
--
Wei Yang | yangw@slac.stanford.edu<mailto:yangw@slac.stanford.edu> | 650-926-3338(O)
From: Brian Lin <notifications@github.com>
Reply-To: wyang007/rucioN2N-for-Xcache <reply@reply.github.com>
Date: Monday, February 3, 2020 at 7:08 AM
To: wyang007/rucioN2N-for-Xcache <rucioN2N-for-Xcache@noreply.github.com>
Cc: Wei Yang <yangw@slac.stanford.edu>, Mention <mention@noreply.github.com>
Subject: Re: [wyang007/rucioN2N-for-Xcache] link with libXrdPfc instead of libXrdFileCache for Xrootd-5 (#1)
@wyang007<https://github.com/wyang007> we need this change to get the XRootD 5 RC1 into Ilija's hands for his ATLAS XCaches
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#1?email_source=notifications&email_token=ABHVGA3OVZUXVTXIF75CBH3RBAXOHA5CNFSM4KOWJVK2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKUFYII#issuecomment-581458977>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABHVGA4C7WJLRVPRFRXCPOTRBAXOHANCNFSM4KOWJVKQ>.
|
wyang007
added a commit
that referenced
this pull request
Nov 10, 2020
link with libXrdPfc instead of libXrdFileCache for Xrootd-5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to this change: xrootd/xrootd@d77e153
a change in the Makefile is needed to build against Xrootd-5