fix(ui): describe mentions suggestions to assistive tech#85
Merged
Conversation
Contributor
|
ECC bundle files are already tracked in this repository. Skipping generation of another bundle PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
aria-describedbyaria-describedbyvalues when internal suggestion hints are presentValidation
CI / qualitypassed for head2aab17ed3109a3296be10f67f96509b75a3c50a0.npm run lint:ui,npm run typecheck:ui,npm run test:ui,npm run build:ui,npm run build:docs.src/components/form/controls/Mentions/Mentions.test.tsxcoverage for suggestion descriptions, externalaria-describedby, and input changes.Failed to create unified exec process: No such file or directory.Notes
codebase-memory-mcpgraph tools were not exposed in this session, so this run used repository files through GitHub as the AGENTS.md fallback.mainat11041bb72fcca72ae77d23b74ac912fc09b23bfdand avoids the still-open Carousel PR fix(ui): add carousel rotation control #82, ImagePreview PR fix(ui): improve image preview accessibility #83, and Drawer PR fix(ui): trap drawer keyboard focus #84.