Skip to content

ci: enable memory profiling for benchmarks - #119

Merged
robjtede merged 1 commit into
mainfrom
t3/add-memory-profiling-ci
Nov 7, 2026
Merged

robjtede merged 1 commit into
mainfrom
t3/add-memory-profiling-ci

Conversation

@robjtede

@robjtede robjtede commented Nov 7, 2026

Copy link
Copy Markdown
Member

Summary

  • Run CodSpeed benchmarks in both walltime and memory modes.
  • Build benchmark binaries for both measurement modes.

Testing

  • Prettier check passed for .github/workflows/benchmark.yml.
  • Not run: CI benchmark execution.

@coderabbitai

coderabbitai Bot commented Nov 7, 2026

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The benchmark build now enables memory measurement alongside wall-time measurement. The CodSpeed action also runs both measurement modes.

Merge Risk: Minimal · up to a5efd

The workflow enables both benchmark modes consistently. Available timing does not establish a timeout regression, so no actionable merge-blocking risk remains after normal checks.

Pre-merge checks: Passed 5

Check name Status Explanation
Title check Passed The title clearly describes the addition of memory profiling to benchmarks.
Description check Passed The description accurately describes the changes to both benchmark build and measurement modes.
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Tip

🎯 Customize your risk assessments

Guide how CodeRabbit assesses merge risk and security architecture risk. Highlight sensitive changes and explain your security boundaries using Merge Risk Instructions and Security Risk Instructions in your review settings. Security architecture risk assessments require the Advanced plan or above.

✅ Automatic approvals, with your rules

Let CodeRabbit approve pull requests once required threads are resolved, pre-merge checks pass, and your risk limits are met. Enable Automatic approvals in review settings, with overrides for teams or file paths.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: e763fa97-9288-4772-b9f9-3294fc718cc9
Commits

Reviewing files that changed from the base of the PR and between d48821a and a5efd75.

Files selected for processing: 1

  • .github/workflows/benchmark.yml

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

@codspeed

codspeed Bot commented Nov 7, 2026 •

Copy link
Copy Markdown

Merging this PR will degrade performance by 12.5%

1 warning

⚠️ 1 benchmark with a significant change ran in a different software environment

Its base and head results were measured with a different OS or toolchain, such as compiler, runtime or library versions, so the change might come from this difference rather than from the code. Open the benchmark to see what changed.

See affected benchmarks

❌ 1 (👁 1) regressed benchmark
✅ 112 untouched benchmarks
🆕 113 new benchmarks
⏩ 77 skipped benchmarks1

Performance Changes

Mode Benchmark BASE HEAD Efficiency
🆕 Memory bws N/A 0 B N/A
🆕 Memory chunk N/A 0 B N/A
🆕 Memory chunk_data N/A 0 B N/A
🆕 Memory chunk_ext_empty N/A 0 B N/A
🆕 Memory chunk_ext_multi N/A 0 B N/A
🆕 Memory chunk_ext_param_quoted N/A 0 B N/A
🆕 Memory chunk_ext_param_token N/A 0 B N/A
🆕 Memory chunk_ext_val_quoted N/A 0 B N/A
🆕 Memory chunk_ext_val_token N/A 0 B N/A
🆕 Memory chunk_header N/A 0 B N/A
🆕 Memory chunk_size_long N/A 0 B N/A
🆕 Memory chunk_size_short N/A 0 B N/A
🆕 Memory last_chunk N/A 0 B N/A
🆕 Memory quoted_pair N/A 0 B N/A
🆕 Memory quoted_string N/A 0 B N/A
🆕 Memory token N/A 0 B N/A
🆕 Memory adapter_ci_canonical N/A 0 B N/A
🆕 Memory adapter_ci_mixed_case N/A 0 B N/A
🆕 Memory adapter_strict N/A 0 B N/A
🆕 Memory direct_ci_canonical N/A 0 B N/A
... ... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.


Comparing t3/add-memory-profiling-ci (a5efd75) with main (2dedee2)

Open in CodSpeed

Footnotes

  1. 77 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@robjtede
robjtede added this pull request to the merge queue Nov 7, 2026
@robjtede
robjtede removed this pull request from the merge queue due to a manual request Nov 7, 2026
@robjtede
robjtede merged commit f7ee6d0 into main Nov 7, 2026
10 checks passed
@robjtede
robjtede deleted the t3/add-memory-profiling-ci branch November 7, 2026 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant