Skip to content

fix: update just recipes for print format changes - #314

Merged
robjtede merged 1 commit into
mainfrom
small-improvement-20261102
Nov 2, 2026
Merged

robjtede merged 1 commit into
mainfrom
small-improvement-20261102

Conversation

@robjtede

@robjtede robjtede commented Nov 2, 2026

Copy link
Copy Markdown
Member

Summary

  • Update protobuf helper recipes to use the current --print-format option.
  • Use edit for JSON-to-protobuf output in the encode and rewrite helpers.

Testing

  • bash /tmp/protobug-helper-check.sh — passed helper checks and round trips.
  • just --unstable --fmt --check — passed.
  • Full workspace tests — not run.

@coderabbitai

coderabbitai Bot commented Nov 2, 2026

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 3ec9cf99-95a3-4061-9904-400f4fc30f41
Commits

Reviewing files that changed from the base of the PR and between 1970b9e and 0d684eb.

Files selected for processing: 1
  • justfile

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Walkthrough

The proto-json and proto-jq targets now use --print-format json. The proto-jq-encode and proto-jq-rewrite targets also update this option and replace encode with edit, passing JSON input and the requested output format. The optional message argument, jq transformation, and rewrite target’s temporary-file replacement flow remain unchanged.

Merge Risk: Minimal · up to 0d684

The helpers now use supported CLI options and commands while preserving the rewrite safeguards. No actionable merge-blocking risk remains.

Pre-merge checks: Passed 5
Check name Status Explanation
Title check Passed The title clearly and concisely identifies the main change: updating just recipes for print format changes.
Description check Passed The description directly covers the recipe updates, command changes, and reported testing for the changeset.
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@robjtede
robjtede added this pull request to the merge queue Nov 2, 2026
Merged via the queue into main with commit 9162fe8 Nov 2, 2026
8 checks passed
@robjtede
robjtede deleted the small-improvement-20261102 branch November 2, 2026 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant