fix(session): hide session pill when only one session is registered#12
Open
johnkferguson wants to merge 1 commit into
Open
fix(session): hide session pill when only one session is registered#12johnkferguson wants to merge 1 commit into
johnkferguson wants to merge 1 commit into
Conversation
The session pill renders unconditionally, even when sessionModel.count is 1 — wasted UI since there's nothing to switch to. The "▾" caret already hides in that case (Main.qml:551), but the pill itself doesn't. Bind sessionPill.visible to (count > 1). When hidden, the ColumnLayout drops the item and its spacing, leaving a small amount of empty space at the bottom of the card (the loginCard height is still hardcoded).
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The session pill renders unconditionally, even when
sessionModel.countis 1. The "▾" caret already hides in that case (Main.qml:551), but the pill itself doesn't — so it sits there showing a session you can't switch away from.One-line fix: bind
sessionPill.visibletocount > 1. The defensivetypeof sessionModel !== "undefined"half matches the existing style in the same block (the innerText { text: ... }does the same check).