feat(M89): PD Topology-Aware Testing#191
Merged
Merged
Conversation
- TopologyNode, NodePairResult, TopologyReport dataclasses - parse_topology() for proxy discovery response parsing - build_pair_matrix() generates all prefill×decode pairs - scan_topology() tests all pairs via pluggable test function - format_topology() rich terminal output with verdict matrix - topology-scan CLI subcommand with --proxy, --prompt, --samples, --json, --mock - --prefill-node and --decode-node flags on compare-logprobs - 23 tests covering dataclasses, parsing, scanning, formatting, JSON export, CLI - Updated ROADMAP.md (M88 ✅) and docs/iterations/current.md Closes #190
hlin99-Review-Bot
approved these changes
Apr 6, 2026
hlin99-Review-Bot
left a comment
hlin99-Review-Bot
left a comment
There was a problem hiding this comment.
LGTM. Clean design — pluggable test_fn, proper Cartesian coverage, well-structured dataclasses with verdict thresholds. 23 tests cover all paths. CI green. Docs updated. ✅
hlin99-Review-BotX
approved these changes
Apr 6, 2026
hlin99-Review-BotX
left a comment
hlin99-Review-BotX
left a comment
There was a problem hiding this comment.
Clean implementation. Pluggable test_fn design is solid, Cartesian pair matrix covers all combinations, verdict thresholds are sensible. 23 tests with good coverage. CLI integration (topology-scan + node flags on compare-logprobs) is well-structured. CI green. ROADMAP/docs updated. ✅
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implement PD topology-aware testing for discovering and testing all prefill/decode node pairs in a xPyD-proxy cluster.
Changes
src/xpyd_acc/topology.py: Core module withTopologyNode,NodePairResult,TopologyReportdataclasses,parse_topology(),build_pair_matrix(),scan_topology(),format_topology()topology-scansubcommand with--proxy,--prompt,--samples,--json,--mockflags--prefill-nodeand--decode-nodeflags tocompare-logprobsfor direct node-pair testingtests/test_topology.py: 23 tests covering all functionalityKey Design
test_fninscan_topology()enables both mock and live testingCloses #190