feat(M90): Hardware Precision Baseline Library#193
Merged
Conversation
- hw_baseline.py module: HardwareProfile, PrecisionRange, BaselineDB, classify_difference()
- 8 built-in profiles: A100/H100/H200/Gaudi2/Gaudi3 across BF16/FP16/FP8/INT8-KV
- classify_difference() returns per-metric verdicts: expected/suspicious/likely_bug/unknown
- BaselineDB: list, get, add, remove, find, export/import JSON
- CLI: baseline-db {list|show|export|import|find|classify}
- 33 tests covering all dataclasses, DB ops, classification, formatting, serialization
- ROADMAP.md updated with M90 ✅
Closes #192
hlin99-Review-Bot
approved these changes
Apr 6, 2026
hlin99-Review-Bot
left a comment
hlin99-Review-Bot
left a comment
There was a problem hiding this comment.
LGTM. Clean implementation — dataclasses, classification logic, CLI integration, and 33 tests all look solid. CI green across 3.10/3.11/3.12. Approve ✅
hlin99-Review-BotX
approved these changes
Apr 6, 2026
hlin99-Review-BotX
left a comment
hlin99-Review-BotX
left a comment
There was a problem hiding this comment.
Clean implementation — well-structured dataclasses, solid classification logic with proper severity thresholds, comprehensive 33 tests, and good CLI integration. 8 built-in profiles cover the key hardware configs. Approve ✅
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Hardware Precision Baseline Library — maintains reference precision profiles for common GPU hardware configurations and classifies observed numerical differences as expected hardware variance or likely software bugs.
Changes
hw_baseline.py:HardwareProfile,PrecisionRange,BaselineDB,classify_difference(), formatting functionsbaseline-db {list|show|export|import|find|classify}subcommandsCloses #192