Skip to content

refactor: remove sim-dependent tests and adapters#269

Merged
hlin99 merged 1 commit into
mainfrom
refactor/remove-integration-tests
Apr 6, 2026
Merged

refactor: remove sim-dependent tests and adapters#269
hlin99 merged 1 commit into
mainfrom
refactor/remove-integration-tests

Conversation

@hlin99
Copy link
Copy Markdown
Member

@hlin99 hlin99 commented Apr 6, 2026

Tests migrated to xPyD-integration. Remove 12 test files + sim_adapter + dummy shim + xpyd-sim dependency.

Copy link
Copy Markdown
Contributor

@hlin99-Review-Bot hlin99-Review-Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Idea: ✅ Good — migrating sim-dependent tests to xPyD-integration and removing the xpyd-sim dependency is the right call.

Code issues (request changes):

  1. CI is redtest (3.11) fails with ModuleNotFoundError: No module named 'starlette' in tests/test_distributed.py. This looks pre-existing (unrelated to your diff), but policy requires all checks green before merge. Either fix the starlette dep or skip/mark that test.

  2. Missing docs/iterations/current.md update — per REVIEW_POLICY.md, every PR must update this file with what was done this iteration. Please add an entry.

Otherwise the diff itself looks clean — pure deletions of the right files + the dep removal from pyproject.toml. 👍

Copy link
Copy Markdown

@hlin99-Review-BotX hlin99-Review-BotX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Idea: ✅ Good — cleaning out sim-dependent tests after migration to xPyD-integration makes sense. Pure deletions, no risk of introducing bugs.

Requesting changes:

  1. CI redtest (3.11) fails (ModuleNotFoundError: starlette), test (3.10) and test (3.12) cancelled. Per policy, all checks must be green before merge. Likely need to add starlette to test deps or fix/skip the offending test.

  2. docs/iterations/current.md not updated — policy requires every PR to document what was done this iteration.

Diff itself is clean. Fix CI + add iteration docs and this is good to go. 👍

Tests migrated to xPyD-integration repo.
Remove:
- 12 test files (189 tests) that depend on xpyd-sim
- xpyd_bench/sim_adapter/ module
- xpyd_bench/dummy/ shim module
- xpyd-sim dependency from pyproject.toml
@hlin99 hlin99 force-pushed the refactor/remove-integration-tests branch from ea5179d to 05d72d6 Compare April 6, 2026 12:13
@hlin99 hlin99 merged commit d8c0c30 into main Apr 6, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants