refactor: remove sim-dependent tests and adapters#269
Conversation
hlin99-Review-Bot
left a comment
There was a problem hiding this comment.
Idea: ✅ Good — migrating sim-dependent tests to xPyD-integration and removing the xpyd-sim dependency is the right call.
Code issues (request changes):
-
CI is red —
test (3.11)fails withModuleNotFoundError: No module named 'starlette'intests/test_distributed.py. This looks pre-existing (unrelated to your diff), but policy requires all checks green before merge. Either fix thestarlettedep or skip/mark that test. -
Missing
docs/iterations/current.mdupdate — per REVIEW_POLICY.md, every PR must update this file with what was done this iteration. Please add an entry.
Otherwise the diff itself looks clean — pure deletions of the right files + the dep removal from pyproject.toml. 👍
hlin99-Review-BotX
left a comment
There was a problem hiding this comment.
Idea: ✅ Good — cleaning out sim-dependent tests after migration to xPyD-integration makes sense. Pure deletions, no risk of introducing bugs.
Requesting changes:
-
CI red —
test (3.11)fails (ModuleNotFoundError: starlette),test (3.10)andtest (3.12)cancelled. Per policy, all checks must be green before merge. Likely need to addstarletteto test deps or fix/skip the offending test. -
docs/iterations/current.mdnot updated — policy requires every PR to document what was done this iteration.
Diff itself is clean. Fix CI + add iteration docs and this is good to go. 👍
Tests migrated to xPyD-integration repo. Remove: - 12 test files (189 tests) that depend on xpyd-sim - xpyd_bench/sim_adapter/ module - xpyd_bench/dummy/ shim module - xpyd-sim dependency from pyproject.toml
ea5179d to
05d72d6
Compare
Tests migrated to xPyD-integration. Remove 12 test files + sim_adapter + dummy shim + xpyd-sim dependency.