Collapse duplicated accessor methods#69
Closed
thodson-usgs wants to merge 1 commit into
Closed
Conversation
The three interp methods (linear/nearest/cubic) had identical 3-line bodies differing only in the method string; extract a private `_interp`. most_common/least_common were near-identical with an `anti_mode` flag already threaded through to `compute_mode`; extract a private `_mode` that also builds the error label from the same flag. No behavior change; public API unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small refactor of
regrid.pyaccessor methods — no behavior change, public API unchanged.linear/nearest/cubichad identical 3-line bodies differing only in the method string. Extracted a private_interp.most_common/least_commonwere near-identical with ananti_modeflag already threaded through tocompute_mode. Extracted a private_modethat also builds the error label from the same flag.Net: +29 / -32 LOC in one file. Existing tests pass.
Touches the same methods as #68 — whichever merges first, the other rebases cleanly.