Skip to content

Fix wheel build missing subpackages#448

Merged
aaronspring merged 3 commits into
mainfrom
fix/wheel-subpackages
Jun 11, 2026
Merged

Fix wheel build missing subpackages#448
aaronspring merged 3 commits into
mainfrom
fix/wheel-subpackages

Conversation

@aaronspring

Copy link
Copy Markdown
Collaborator

Summary

  • Replaces packages = ["xskillscore"] with [tool.setuptools.packages.find] auto-discovery
  • The old config caused xskillscore.core, xskillscore.versioning, and xskillscore.tests to be omitted from built wheels, making installed packages non-functional
  • Auto-discovery picks up all subpackages automatically, including any added in future

Closes #423

Test plan

  • Verify python -m build --wheel produces a wheel containing xskillscore/core/, xskillscore/versioning/
  • Existing test suite passes (pytest -n auto)

🤖 Generated with Claude Code

Replaces the manual packages list with [tool.setuptools.packages.find]
so that xskillscore.core, xskillscore.versioning, and any future
subpackages are automatically included in built wheels.

Fixes #423

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@codecov

codecov Bot commented Jun 11, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.57%. Comparing base (eccc957) to head (0870f4b).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #448      +/-   ##
==========================================
+ Coverage   94.49%   94.57%   +0.08%     
==========================================
  Files          27       27              
  Lines        2836     2841       +5     
==========================================
+ Hits         2680     2687       +7     
+ Misses        156      154       -2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@aaronspring aaronspring merged commit e457985 into main Jun 11, 2026
14 of 15 checks passed
@aaronspring aaronspring deleted the fix/wheel-subpackages branch June 11, 2026 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix wheel build failed

1 participant