Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR migrates the project to use GSP v1.0 architecture, reorganizing the P/Invoke code structure from the C++ side. The changes establish a cleaner separation between core GSP functionality and platform-specific adapters (Rhino), introduce platform-independent geometry types, and refactor the native bridge into a more maintainable extension-based structure.
Key Changes:
- Introduced platform-independent geometry types (
Vec2,Vec3,Mesh) and core utilities (Serializer,Platform,MarshalHelper) - Reorganized namespace structure:
GSPfor core,GSP.Adapters.Rhinofor Rhino-specific code,igMesh.Nativefor native bridge functions - Updated version from 0.5.9 to 0.6.0
Reviewed changes
Copilot reviewed 33 out of 35 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
igm/*.cs (multiple files) |
Added new namespace imports for GSP adapters and igMesh native bridge |
igm/01_meshInfo.cs |
Updated native bridge class references from GSP.NativeBridge to igMeshBridge |
igm/01_meshIO.cs |
Code formatting improvements and reorganization |
igm/03_meshAdjacency.cs |
Fixed string indentation alignment |
igm/00_igmInfo.cs |
Version bump to 0.6.0 |
GeoSharPlusNET/Wrapper.cs |
Moved to GSP.Adapters.Rhino namespace |
GeoSharPlusNET/NativeBridge.cs |
Refactored to igMeshBridge class using new Platform utilities |
GeoSharPlusNET/MeshUtils.cs |
Updated to use new namespace structure and igMeshBridge |
GeoSharPlusNET/Geometry/*.cs |
New platform-independent geometry types |
GeoSharPlusNET/Core/*.cs |
New core utilities for serialization, marshaling, and platform detection |
GeoSharPlusNET/Adapters/Rhino/*.cs |
New Rhino adapter implementation |
GeoSharPlusNET/Extensions/igMesh/*.cs |
New high-level igMesh utilities and documentation |
GeoSharPlusCPP/src/API/BridgeAPI.cpp |
Updated include path |
GeoSharPlusCPP/CMakeLists.txt |
Corrected comment text |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the GSP
v1.0version for organizing P/Invoke code from the CPP side.