Skip to content

Make includeGlobalDBObjects work for schema all#760

Open
tsg wants to merge 1 commit intomainfrom
make_includeglobaloptions_work_for_schema_all
Open

Make includeGlobalDBObjects work for schema all#760
tsg wants to merge 1 commit intomainfrom
make_includeglobaloptions_work_for_schema_all

Conversation

@tsg
Copy link
Member

@tsg tsg commented Mar 9, 2026

Description

This changes includeGlobalDBObjects to respect it's false value also when schemas: * is requested. With the default to false the option was ignored when not changing the schemas value.

Related Issue(s)

Type of Change

Please select the relevant option(s):

  • 🐛 Bug fix (non-breaking change that fixes an issue)
  • ✨ New feature (non-breaking change that adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 📚 Documentation update
  • 🔧 Refactoring (no functional changes)
  • ⚡ Performance improvement
  • 🧪 Test coverage improvement
  • 🔨 Build/CI changes
  • 🧹 Code cleanup

Testing

  • Unit tests added/updated
  • Integration tests added/updated
  • Manual testing performed
  • All existing tests pass

@github-actions
Copy link

github-actions bot commented Mar 9, 2026

Merging this branch will decrease overall coverage

Impacted Packages Coverage Δ 🤖
github.com/xataio/pgstream/pkg/snapshot/generator/postgres/schema/pgdumprestore 89.09% (-0.04%) 👎

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/xataio/pgstream/pkg/snapshot/generator/postgres/schema/pgdumprestore/pg_options_generator.go 98.81% (-1.19%) 84 (+7) 83 (+6) 1 (+1) 👎

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/xataio/pgstream/pkg/snapshot/generator/postgres/schema/pgdumprestore/pg_options_generator_test.go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix: Apply IncludeGlobalDBObjects when using wildcard schema ('*')

1 participant