Additional Result and Maybe extensions by xavierjohn · Pull Request #357 · xavierjohn/Trellis

xavierjohn · 2026-03-29T23:12:16Z

Result Extensions (5 new)

Method	Purpose
`Check`	Validate without losing the pipeline value (full async matrix: 7 files)
`BindZip`	Sequential tuple accumulation — each step depends on the previous (T4-generated up to
9-tuple)
`MapIf`	Conditional pure transformation gated by bool or predicate
`EnsureNotNull`	Null-guard narrowing `Result<T?>` → `Result<T>` (class + struct)
`GetValueOrDefault`	Terminal extraction with value, `Func<T>`, or `Func<Error, T>` overloads

Maybe Instance Methods (5 new)

Method	Purpose
`Bind`	FlatMap for fluent optional chains
`Or`	Fallback values (4 overloads: value, Func, Maybe, Func<Maybe>)
`Where`	Predicate filter — None if predicate fails
`Tap`	Side effect without changing the Maybe
`GetValueOrDefault(Func<T>)`	Lazy default evaluation

Collection Helpers (3 new)

Method	Purpose
`TryFirst` / `TryLast`	Safe `IEnumerable` → `Maybe<T>` bridge (no exceptions)
`Choose`	Filter + unwrap `IEnumerable<Maybe<T>>` to values

…ueOrDefault, Maybe.Bind/Or/Where/Tap, TryFirst/TryLast, Choose Result extensions: - Check: validate without losing pipeline value (sync + full async matrix) - BindZip: sequential tuple accumulation with T4 template (2→9 tuples) - MapIf: conditional pure transformation (bool + predicate overloads) - EnsureNotNull: null-guard + type narrowing for class and struct - GetValueOrDefault: terminal extraction (value, Func<T>, Func<Error,T>) Maybe instance methods: - Bind: flatMap for Maybe chains - Or: fallback value/Maybe (4 overloads) - Where: predicate filter - Tap: side effect - GetValueOrDefault(Func<T>): lazy default Collection helpers: - TryFirst/TryLast: safe IEnumerable → Maybe bridge - Choose: filter+unwrap IEnumerable<Maybe<T>> 108 new tests, all passing. Zero build warnings. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Update trellis-api-reference.md, Trellis.Results README, and maybe-type.md docfx article with Check, BindZip, MapIf, EnsureNotNull, GetValueOrDefault, Maybe.Bind/Or/Where/Tap, TryFirst/TryLast, and Choose. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

github-actions · 2026-03-29T23:15:01Z

Test Results

4 253 tests +108 4 238 ✅ +108 4m 3s ⏱️ -24s
14 suites ± 0 15 💤 ± 0
14 files ± 0 0 ❌ ± 0

Results for commit 5e3e0ba. ± Comparison against base commit 61776a4.

♻️ This comment has been updated with latest results.

codecov · 2026-03-29T23:15:25Z

Codecov Report

❌ Patch coverage is 77.38516% with 64 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.02%. Comparing base (61776a4) to head (5e3e0ba).
⚠️ Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
...Results/src/Result/Extensions/BindZip.ValueTask.cs	0.00%	16 Missing ⚠️
...esults/src/Result/Extensions/BindZip.Task.Right.cs	0.00%	15 Missing ⚠️
...s/src/Result/Extensions/BindZip.ValueTask.Right.cs	0.00%	15 Missing ⚠️
...llis.Results/src/Result/Extensions/BindZip.Task.cs	52.94%	6 Missing and 2 partials ⚠️
...ts/src/Result/Extensions/BindZip.ValueTask.Left.cs	0.00%	4 Missing ⚠️
...s.Results/src/Result/Extensions/Check.Task.Left.cs	83.33%	1 Missing ⚠️
....Results/src/Result/Extensions/Check.Task.Right.cs	92.85%	1 Missing ⚠️
...rellis.Results/src/Result/Extensions/Check.Task.cs	93.75%	1 Missing ⚠️
...ults/src/Result/Extensions/Check.ValueTask.Left.cs	80.00%	1 Missing ⚠️
...lts/src/Result/Extensions/Check.ValueTask.Right.cs	92.85%	1 Missing ⚠️
... and 1 more

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #357      +/-   ##
==========================================
- Coverage   85.32%   85.02%   -0.31%     
==========================================
  Files         205      223      +18     
  Lines        7174     7457     +283     
  Branches     1398     1447      +49     
==========================================
+ Hits         6121     6340     +219     
- Misses        656      718      +62     
- Partials      397      399       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

- Add missing resultTask null checks in BindZipAsync overloads - Add missing ValueTask/ValueTask tuple chaining overload to T4 template - Remove unnecessary notnull constraint from Choose<T, TResult> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Adds new functional helpers to Trellis’ ROP surface area by expanding Result<T> pipelines (validation, conditional mapping, tuple accumulation, terminal extraction) and enhancing Maybe<T> ergonomics (bind/filter/fallback/tap) plus safe collection-to-Maybe helpers, with accompanying tests and documentation updates.

Changes:

Added new Result<T> extensions: Check, BindZip (T4 template), MapIf, EnsureNotNull, and GetValueOrDefault.
Added new Maybe<T> instance methods (Bind, Or, Where, Tap, lazy GetValueOrDefault) and collection helpers (TryFirst/TryLast, Choose).
Updated docs (API reference, Maybe article, package README) and added/extended tests for the new APIs.

Reviewed changes

Copilot reviewed 31 out of 31 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
trellis-api-reference.md	Documents newly added `Result`/`Maybe` APIs and collection helpers.
docs/docfx_project/articles/maybe-type.md	Updates Maybe guide with new methods and examples.
Trellis.Results/README.md	Adds README sections describing new extensions and collection helpers.
Trellis.Results/src/Trellis.Results.csproj	Registers new T4 template output and template file metadata.
Trellis.Results/src/Result/Extensions/MapIf.cs	Implements `Result<T>.MapIf(...)` overloads.
Trellis.Results/src/Result/Extensions/GetValueOrDefault.cs	Implements terminal `Result<T>.GetValueOrDefault(...)` overloads.
Trellis.Results/src/Result/Extensions/Ensure.cs	Adds `EnsureNotNull` narrowing for `Result<T?> → Result<T>` (class/struct).
Trellis.Results/src/Result/Extensions/Check.cs	Implements sync `Check` extensions.
Trellis.Results/src/Result/Extensions/Check.Task.cs	Implements Task “both async” `CheckAsync`.
Trellis.Results/src/Result/Extensions/Check.Task.Left.cs	Implements Task “left async” `CheckAsync`.
Trellis.Results/src/Result/Extensions/Check.Task.Right.cs	Implements Task “right async” `CheckAsync`.
Trellis.Results/src/Result/Extensions/Check.ValueTask.cs	Implements ValueTask “both async” `CheckAsync`.
Trellis.Results/src/Result/Extensions/Check.ValueTask.Left.cs	Implements ValueTask “left async” `CheckAsync`.
Trellis.Results/src/Result/Extensions/Check.ValueTask.Right.cs	Implements ValueTask “right async” `CheckAsync`.
Trellis.Results/src/Result/Extensions/BindZip.cs	Implements base `BindZip` (scalar → 2-tuple).
Trellis.Results/src/Result/Extensions/BindZip.Task.cs	Implements Task async `BindZipAsync` (scalar → 2-tuple, both async).
Trellis.Results/src/Result/Extensions/BindZip.Task.Left.cs	Implements Task async `BindZipAsync` (scalar → 2-tuple, left async).
Trellis.Results/src/Result/Extensions/BindZipTs.g.tt	T4 template generating tuple-growing `BindZip`/`BindZipAsync` overloads up to 9-tuple.
Trellis.Results/src/Maybe/Maybe{T}.cs	Adds new `Maybe<T>` instance methods and lazy default factory overload.
Trellis.Results/src/Maybe/Extensions/TryFirst.cs	Adds `TryFirst`/`TryLast` enumerable helpers returning `Maybe<T>`.
Trellis.Results/src/Maybe/Extensions/Choose.cs	Adds `Choose` to filter/unwrap `IEnumerable<Maybe<T>>`.
Trellis.Results/tests/Results/Extensions/MapIfTests.cs	Adds unit tests for `MapIf`.
Trellis.Results/tests/Results/Extensions/GetValueOrDefaultTests.cs	Adds unit tests for `Result.GetValueOrDefault`.
Trellis.Results/tests/Results/Extensions/EnsureTests.cs	Adds unit tests for `EnsureNotNull` narrowing behavior.
Trellis.Results/tests/Results/Extensions/CheckTests.cs	Adds unit tests for sync `Check`.
Trellis.Results/tests/Results/Extensions/CheckTests.Task.cs	Adds Task async-variant tests for `CheckAsync`.
Trellis.Results/tests/Results/Extensions/CheckTests.ValueTask.cs	Adds ValueTask async-variant tests for `CheckAsync`.
Trellis.Results/tests/Results/Extensions/BindZipTests.cs	Adds unit tests for `BindZip` and some async scenarios.
Trellis.Results/tests/Maybes/MaybeMethodTests.cs	Adds tests for new `Maybe<T>` instance methods.
Trellis.Results/tests/Maybes/MaybeEdgeCaseTests.cs	Adjusts call-site to disambiguate `GetValueOrDefault` overload.
Trellis.Results/tests/Maybes/Extensions/CollectionExtensionTests.cs	Adds tests for `TryFirst`/`TryLast`/`Choose`.

Copilot · 2026-03-29T23:18:01Z

Trellis.Results/src/Result/Extensions/BindZip.Task.cs

+using System.Diagnostics;
+


using System.Diagnostics; appears to be unused in this file (no DebuggerStepThrough attribute or other System.Diagnostics types referenced explicitly). With EnforceCodeStyleInBuild=true this will trigger IDE0005 and fail the build; remove the using (or add the intended attribute/usage).

Suggested change

using System.Diagnostics;

Copilot · 2026-03-29T23:18:02Z

Trellis.Results/src/Result/Extensions/BindZip.Task.Left.cs

+using System.Diagnostics;
+


using System.Diagnostics; appears to be unused in this file. Because code style is enforced during build, this will raise IDE0005 (unused using) and fail CI; remove the using (or add the intended DebuggerStepThrough/other diagnostics usage).

Suggested change

using System.Diagnostics;

Copilot · 2026-03-29T23:18:02Z

trellis-api-reference.md

+// T4-generated: tuple continuation overloads (2 → 9 tuples)
+// e.g., Result<(T1, T2, T3)> BindZip<T1, T2, T3>(this Result<(T1, T2)>, Func<T1, T2, Result<T3>>)
+// Async: BindZipAsync with Task/ValueTask Left/Right/Both variants
+```


The API reference claims BindZipAsync has Task/ValueTask Left/Right/Both variants, but the code currently only provides scalar BindZipAsync for Task<Result<T>> (Left/Both) and tuple overloads where ValueTask variants are Left/Right only (no ValueTask Both, and no scalar right/ValueTask overloads). Please align the documentation with the actual overload set, or add the missing overloads so the statement is true.

Copilot · 2026-03-29T23:18:02Z

docs/docfx_project/articles/maybe-type.md

+// Choose with selector
+IEnumerable<string> emails = users.Choose(u => u.Email);


In the “Choose with selector” example, users.Choose(u => u.Email) won’t compile because Choose is defined for IEnumerable<Maybe<T>>, not IEnumerable<T>. Either change the example to call Choose on an IEnumerable<Maybe<User>> (or on users.Select(u => u.Email)), or document/add an overload that supports IEnumerable<T> + selector returning Maybe<TResult>.

Suggested change

// Choose with selector

IEnumerable<string> emails = users.Choose(u => u.Email);

// Choose with selector (via projection)

IEnumerable<string> emailsWithSelector = users

.Select(u => u.Email) // Func<User, Maybe<string>>

.Choose();

Add [GeneratedCode] attribute to BindZipTs.g.tt output classes. Simplify Directory.Build.props ExcludeByFile to **/*.g.cs. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

The IScalarValue interface requires both TryCreate(TPrimitive, string?) and TryCreate(string?, string?). The Quantity test stubs only had the primitive overload, causing a CS0535 compilation error in the generator test. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 32 out of 32 changed files in this pull request and generated 2 comments.

Copilot · 2026-03-29T23:28:43Z

Trellis.Results/src/Result/Extensions/BindZip.Task.Left.cs

+using System.Diagnostics;
+


using System.Diagnostics; is unused in this file. With warnings treated as errors, this unnecessary using directive will break the build (CS8019). Remove it.

Suggested change

using System.Diagnostics;

Copilot · 2026-03-29T23:28:43Z

Trellis.Results/src/Result/Extensions/BindZip.cs

+public static partial class BindZipExtensions
+{
+    /// <summary>
+    /// Binds a function to the Result value and zips both values into a tuple on success.
+    /// If the source or the function result is a failure, returns that failure.
+    /// </summary>
+    /// <typeparam name="T1">Type of the input result value.</typeparam>
+    /// <typeparam name="T2">Type of the new result value.</typeparam>
+    /// <param name="result">The result to bind and zip.</param>
+    /// <param name="func">The function to call if the result is successful.</param>
+    /// <returns>A tuple result combining both values on success; otherwise the failure.</returns>
+    public static Result<(T1, T2)> BindZip<T1, T2>(
+        this Result<T1> result,
+        Func<T1, Result<T2>> func)
+    {
+        ArgumentNullException.ThrowIfNull(func);
+        using var activity = RopTrace.ActivitySource.StartActivity();
+


BindZip currently only has sync, Task-left, and Task-both async variants for the 2-tuple entry point (Result<T1>). There is no Task-right overload (this Result<T1>, async func) and no ValueTask variants, even though other extensions (e.g., BindAsync) support the full Task/ValueTask matrix. Consider adding the missing overloads (Task.Right, ValueTask.Left/Right/Both) so the API is consistent and matches the documented surface.

Copilot

Pull request overview

Copilot reviewed 33 out of 33 changed files in this pull request and generated 6 comments.

Copilot · 2026-03-29T23:34:41Z

Trellis.Results/src/Result/Extensions/BindZip.Task.cs

+    {
+        ArgumentNullException.ThrowIfNull(resultTask);
+        ArgumentNullException.ThrowIfNull(func);
+        using var activity = RopTrace.ActivitySource.StartActivity();


BindZipAsync starts an activity with StartActivity() (parameterless), which will name the span after the async method (e.g., "BindZipAsync"). Elsewhere in this codebase, async variants explicitly name the activity after the sync operator (e.g., EnsureAsync uses StartActivity(nameof(EnsureExtensions.Ensure)), BindAsync uses nameof(BindExtensions.Bind)) so telemetry stays consistent across sync/async. Consider passing nameof(BindZipExtensions.BindZip) here as well.

Suggested change

using var activity = RopTrace.ActivitySource.StartActivity();

using var activity = RopTrace.ActivitySource.StartActivity(nameof(BindZipExtensions.BindZip));

Copilot · 2026-03-29T23:34:41Z

Trellis.Results/src/Result/Extensions/BindZipTs.g.tt

+        Func<<# WriteTs(i); #>, Task<Result<T<#= outputSize #>>>> func)
+    {
+        ArgumentNullException.ThrowIfNull(func);
+        using var activity = RopTrace.ActivitySource.StartActivity();


In the T4 template, the async BindZipAsync overloads that create activities use StartActivity() without an explicit name. That will likely produce span names like "BindZipAsync" instead of matching the sync operator name. Other ROP async operators in this repo pin the activity name to the sync method (e.g., nameof(BindExtensions.Bind), nameof(EnsureExtensions.Ensure)), so it would be good to use StartActivity(nameof(BindZipExtensions.BindZip)) (or an equivalent constant) in the async overloads generated by this template.

Suggested change

using var activity = RopTrace.ActivitySource.StartActivity();

using var activity = RopTrace.ActivitySource.StartActivity(nameof(BindZipExtensions.BindZip));

Copilot · 2026-03-29T23:34:42Z

Trellis.Results/tests/Results/Extensions/CheckTests.Task.cs

+public class CheckTaskTests
+{


This file name indicates the established async-variant naming scheme used elsewhere in the repo (e.g., EnsureTests.Task.cs contains Ensure_Task_Tests). To stay consistent/readable, consider renaming the test class to match the convention for Task variants (e.g., Check_Task_Tests) and adding the usual <summary>/#region organization used in the other async extension test files.

Copilot · 2026-03-29T23:34:42Z

Trellis.Results/tests/Results/Extensions/CheckTests.ValueTask.cs

+public class CheckValueTaskTests
+{


This async-variant test file (*.ValueTask.cs) doesn’t follow the naming pattern used by other ValueTask variant tests in this repo (e.g., EnsureTests.ValueTask.cs contains Ensure_ValueTask_Tests). Consider renaming the class to match the convention (e.g., Check_ValueTask_Tests) and adding the standard <summary> header so it’s clear which async matrix variant the file covers.

Copilot · 2026-03-29T23:34:42Z

Trellis.Results/src/Result/Extensions/MapIf.cs

+    /// <summary>
+    /// Transforms the value if the result is successful and the condition is true.
+    /// Returns the original result unchanged if the condition is false or the result is a failure.
+    /// </summary>
+    public static Result<T> MapIf<T>(this Result<T> result, bool condition, Func<T, T> func)
+    {


These new public extension methods only have <summary> XML docs; they’re missing the usual <typeparam>, <param>, and <returns> tags that other extension methods in this project provide (e.g., Map, Ensure, ToMaybe). Adding full XML doc tags here will keep the generated docs consistent and more useful for consumers.

Copilot · 2026-03-29T23:34:42Z

Trellis.Results/src/Result/Extensions/GetValueOrDefault.cs

+    /// <summary>
+    /// Returns the success value, or the specified default if the result is a failure.
+    /// This is a terminal operator that exits the Result railway.
+    /// </summary>
+    public static TValue GetValueOrDefault<TValue>(this Result<TValue> result, TValue defaultValue) =>
+        result.IsSuccess ? result.Value : defaultValue;
+
+    /// <summary>
+    /// Returns the success value, or evaluates the factory to produce a default if the result is a failure.
+    /// The factory is only invoked on the failure track.
+    /// This is a terminal operator that exits the Result railway.
+    /// </summary>
+    public static TValue GetValueOrDefault<TValue>(this Result<TValue> result, Func<TValue> defaultFactory)
+    {
+        ArgumentNullException.ThrowIfNull(defaultFactory);
+        return result.IsSuccess ? result.Value : defaultFactory();
+    }


These new public GetValueOrDefault overloads only include <summary> docs; they’re missing the standard <typeparam>, <param>, and <returns> XML documentation tags used throughout the rest of the Result extensions. Adding those tags will improve generated API docs and keep documentation consistent.

Add Task.Right, ValueTask.Left, ValueTask.Right, and ValueTask.Both overloads for the initial BindZip entry point, matching the full async matrix provided by other extensions like Bind and Check. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Add missing <typeparam>, <param>, <returns>, and <exception> tags for consistency with other Result extensions. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 40 out of 46 changed files in this pull request and generated 3 comments.

Copilot · 2026-03-29T23:45:55Z

Directory.Build.props

@@ -37,7 +37,7 @@

  <PropertyGroup Label="Coverage">
    <!-- Exclude generated regex state machines and other obj artifacts from coverage to keep metrics meaningful -->


The comment above ExcludeByFile mentions excluding "obj artifacts", but the updated pattern no longer includes an **/obj/** exclusion and now excludes all **/*.g.cs instead. Please update the comment (or the patterns) so the documentation matches what the build actually does for coverage filtering.

Suggested change

Copilot · 2026-03-29T23:45:55Z

Trellis.Results/src/Maybe/Extensions/Choose.cs

+        foreach (var item in source)
+        {
+            if (item.HasValue)
+                yield return item.Value;
+        }


ChooseIterator checks HasValue and then accesses Value, which re-checks state internally (and routes through an exception-throwing accessor). Using TryGetValue(out var value) would avoid the double check and keep the hot-path branch-only.

Copilot · 2026-03-29T23:45:56Z

Trellis.Results/src/Maybe/Extensions/TryFirst.cs

+/// Extension methods for safely querying collections, returning <see cref="Maybe{T}"/> instead of throwing.
+/// </summary>
+[DebuggerStepThrough]
+public static class MaybeTryFirstExtensions


The extension class is named MaybeTryFirstExtensions but it contains both TryFirst and TryLast. Renaming the type (or splitting into two types) would make discovery/intellisense and future maintenance clearer.

Suggested change

public static class MaybeTryFirstExtensions

public static class MaybeTryFirstLastExtensions

The class contains both TryFirst and TryLast methods. A broader name improves discoverability and IntelliSense clarity. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

HasValue + Value does two checks (and Value routes through an exception-throwing accessor). TryGetValue is a single branch. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

CheckTests → Check_Tests, CheckTaskTests → Check_Task_Tests, CheckValueTaskTests → Check_ValueTask_Tests. Add <summary> headers documenting which async variant each file covers. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Pin async span names to the sync operator name, matching the convention used by BindAsync, EnsureAsync, and other ROP operators. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 40 out of 46 changed files in this pull request and generated 3 comments.

Copilot · 2026-03-30T01:16:57Z

Trellis.Results/tests/Results/Extensions/CheckTests.Task.cs

+/// <summary>
+/// Tests for Check.Task.cs where BOTH input and function are async (Task).
+/// Also covers Check.Task.Left.cs (async input, sync function) and
+/// Check.Task.Right.cs (sync input, async function).
+/// </summary>


This test file mixes Both/Left/Right variants, but other async extension tests in this repo are typically split into separate files (e.g., EnsureTests.Task.cs + EnsureTests.Task.Left.cs + EnsureTests.Task.Right.cs). Consider splitting these into separate CheckTests.Task*.cs files (and updating the XML summary) to match the existing organization and keep failures/coverage per-variant easier to locate.

Copilot · 2026-03-30T01:16:57Z

Trellis.Results/tests/Results/Extensions/CheckTests.ValueTask.cs

+/// <summary>
+/// Tests for Check.ValueTask.cs where BOTH input and function are async (ValueTask).
+/// Also covers Check.ValueTask.Left.cs (async input, sync function) and
+/// Check.ValueTask.Right.cs (sync input, async function).
+/// </summary>


This file currently tests ValueTask Both/Left/Right variants together, but other async extension test suites in the repo are commonly split by variant into separate files (e.g., EnsureTests.ValueTask.cs + EnsureTests.ValueTask.Left.cs + EnsureTests.ValueTask.Right.cs). Consider splitting Check ValueTask tests similarly and adjusting the XML summary so file/variant mapping stays consistent.

Copilot · 2026-03-30T01:16:57Z

Trellis.Results/src/Result/Extensions/BindZipTs.g.tt

+        this ValueTask<Result<(<# WriteTs(i); #>)>> resultTask,
+        Func<<# WriteTs(i); #>, ValueTask<Result<T<#= outputSize #>>>> func)
+    {
+        ArgumentNullException.ThrowIfNull(resultTask);


resultTask is a ValueTask<...> struct here, so ArgumentNullException.ThrowIfNull(resultTask) is redundant and will box the struct (unnecessary allocation). Consider removing this check and only validating func (as is done in other ValueTask-based extension overloads).

Suggested change

ArgumentNullException.ThrowIfNull(resultTask);

xavierjohn and others added 2 commits March 29, 2026 15:58

xavierjohn requested a review from Copilot March 29, 2026 23:12

Copilot started reviewing on behalf of xavierjohn March 29, 2026 23:12 View session

Copilot AI reviewed Mar 29, 2026

View reviewed changes

xavierjohn requested a review from Copilot March 29, 2026 23:19

Copilot started reviewing on behalf of xavierjohn March 29, 2026 23:24 View session

xavierjohn and others added 2 commits March 29, 2026 16:26

chore: exclude T4-generated code from coverage

d1210b6

Add [GeneratedCode] attribute to BindZipTs.g.tt output classes. Simplify Directory.Build.props ExcludeByFile to **/*.g.cs. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot AI reviewed Mar 29, 2026

View reviewed changes

xavierjohn requested a review from Copilot March 29, 2026 23:29

Copilot started reviewing on behalf of xavierjohn March 29, 2026 23:30 View session

Copilot AI reviewed Mar 29, 2026

View reviewed changes

xavierjohn and others added 2 commits March 29, 2026 16:35

docs: add full XML doc tags to MapIf and GetValueOrDefault

b0fe026

Add missing <typeparam>, <param>, <returns>, and <exception> tags for consistency with other Result extensions. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

xavierjohn requested a review from Copilot March 29, 2026 23:39

Copilot started reviewing on behalf of xavierjohn March 29, 2026 23:40 View session

fix: add missing newlines at the end of several files

d39c6d7

Copilot AI reviewed Mar 29, 2026

View reviewed changes

xavierjohn and others added 5 commits March 29, 2026 18:05

refactor: rename MaybeTryFirstExtensions to MaybeCollectionExtensions

3678c79

The class contains both TryFirst and TryLast methods. A broader name improves discoverability and IntelliSense clarity. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

perf: use TryGetValue in ChooseIterator to avoid double state check

f9a3655

HasValue + Value does two checks (and Value routes through an exception-throwing accessor). TryGetValue is a single branch. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

docs: fix ExcludeByFile comment to match actual coverage patterns

d0c7b5b

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

fix: use nameof(BindZipExtensions.BindZip) for async activity names

5e3e0ba

Pin async span names to the sync operator name, matching the convention used by BindAsync, EnsureAsync, and other ROP operators. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

xavierjohn requested a review from Copilot March 30, 2026 01:11

Copilot started reviewing on behalf of xavierjohn March 30, 2026 01:12 View session

xavierjohn merged commit 0dee097 into main Mar 30, 2026
6 of 7 checks passed

xavierjohn deleted the dev/xavier/csfunc2026 branch March 30, 2026 01:15

Copilot AI reviewed Mar 30, 2026

View reviewed changes

		// Choose with selector
		IEnumerable<string> emails = users.Choose(u => u.Email);

-// Choose with selector
-IEnumerable<string> emails = users.Choose(u => u.Email);
+// Choose with selector (via projection)
+IEnumerable<string> emailsWithSelector = users
+    .Select(u => u.Email)       // Func<User, Maybe<string>>
+    .Choose();

	using var activity = RopTrace.ActivitySource.StartActivity();
	using var activity = RopTrace.ActivitySource.StartActivity(nameof(BindZipExtensions.BindZip));

		@@ -37,7 +37,7 @@

		<PropertyGroup Label="Coverage">
		<!-- Exclude generated regex state machines and other obj artifacts from coverage to keep metrics meaningful -->

	<!-- Exclude generated regex state machines and other obj artifacts from coverage to keep metrics meaningful -->
	<!-- Exclude generated .g.cs files and regex state machine sources from coverage to keep metrics meaningful -->

	public static class MaybeTryFirstExtensions
	public static class MaybeTryFirstLastExtensions

Conversation

xavierjohn commented Mar 29, 2026

Result Extensions (5 new)

Maybe Instance Methods (5 new)

Collection Helpers (3 new)

Uh oh!

github-actions bot commented Mar 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test Results

Uh oh!

codecov bot commented Mar 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Mar 29, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 29, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 29, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 29, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Mar 29, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 29, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Mar 29, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 29, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 29, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 29, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 29, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 29, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Mar 29, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 29, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 29, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

github-actions bot commented Mar 29, 2026 •

edited

Loading

codecov bot commented Mar 29, 2026 •

edited

Loading