Conversation
oda
reviewed
Jan 13, 2026
| - 追加質問の例なども勉強になった。 | ||
|
|
||
|
|
||
| - suggestされて気になって調べたが、`intersection_update`という呼び出しもとのsetを積集合に書き換えるメソッドもあるみたい(`&=`も同じ) |
There was a problem hiding this comment.
https://docs.python.org/3/library/stdtypes.html#set.intersection_update
こういうリンクを残しておいてもいいと思います。
mamo3gr
reviewed
Jan 14, 2026
Comment on lines
+10
to
+11
| if len(nums1) > len(nums2): | ||
| return self.intersection(nums2, nums1) |
There was a problem hiding this comment.
小さい方をセットにしたいんだよ、という気持ちは以下のようにも書けそうです。
Suggested change
| if len(nums1) > len(nums2): | |
| return self.intersection(nums2, nums1) | |
| smaller = nums1 | |
| larger = nums2 | |
| if len(smaller) > len(larger): | |
| smaller, larger = larger, smaller |
There was a problem hiding this comment.
再帰を使わないのであれば、個人的には以下のように書きたいです。
Suggested change
| if len(nums1) > len(nums2): | |
| return self.intersection(nums2, nums1) | |
| smaller, larger = sorted([nums1, nums2], key=len) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
解く問題
Intersection Of Two Arrays
次に解く問題
Unique Email Addresses