Skip to content

fix: preserve word boundaries between text and inline-formatted nodes #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
xcapaldi wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: preserve word boundaries between text and inline-formatted nodes #22

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 2 additions & 7 deletions parser.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -885,12 +885,7 @@ func extractPlainText(node ast.Node, source []byte) (string, error) {
var buf bytes.Buffer
for child := node.FirstChild(); child != nil; child = child.NextSibling() {
if text, ok := child.(*ast.Text); ok {
if buf.Len() > 0 {
if _, err := buf.WriteRune(' '); err != nil {
return "", fmt.Errorf("buf.WriteRune: %w", err)
}
}
if _, err := buf.Write(bytes.TrimSpace(text.Value(source))); err != nil {
if _, err := buf.Write(text.Value(source)); err != nil {
return "", fmt.Errorf("buf.Write: %w", err)
}
} else {
Expand All @@ -901,7 +896,7 @@ func extractPlainText(node ast.Node, source []byte) (string, error) {
buf.WriteString(childText)
}
}
return buf.String(), nil
return strings.TrimSpace(buf.String()), nil
}

// extractRawMarkdown extracts raw source for a block node, preserving markdown syntax.
Expand Down
2 changes: 1 addition & 1 deletion testdata/golden/title_inline_formatting.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"title": "Title withemphasis andcode",
"title": "Title with emphasis and code",
"description": null,
"yields": [],
"tags": [],
Expand Down