Skip to content

Parse metadata exception handling #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Waqar-ukaea wants to merge 3 commits into
base: main
Choose a base branch
from
+6 −1
Open

Parse metadata exception handling #112

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
13889d1
Assign void material if no volume property found
Waqar-ukaea Jun 3, 2025
cd86e7a
Added similar exception handling for get_surface_property()
Waqar-ukaea Jun 3, 2025
1fb5e41
Added a PROPERTY_NOT_FOUND constant
Waqar-ukaea Jun 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions include/xdg/constants.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,12 +77,15 @@ constexpr int BVH_MAX_DEPTH = 64;
// geometric property type (e.g. material assignment or boundary condition)
// TODO: separate into VolumeProperty and SurfaceProperty
enum class PropertyType {
NOT_FOUND = -2,
BOUNDARY_CONDITION = -1,
MATERIAL = 0,
DENSITY = 1,
TEMPERATURE = 2
};

static const Property PROPERTY_NOT_FOUND {PropertyType::NOT_FOUND, "NOT_FOUND"};

static const std::map<PropertyType, std::string> PROP_TYPE_TO_STR =
{
{PropertyType::BOUNDARY_CONDITION, "BOUNDARY_CONDITION"},
Expand Down
4 changes: 3 additions & 1 deletion src/mesh_manager_interface.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,13 +71,15 @@ MeshManager::surface_has_property(MeshID surface, PropertyType type) const
Property
MeshManager::get_volume_property(MeshID volume, PropertyType type) const
{
if (surface_metadata_.count({volume, type}) == 0)
return PROPERTY_NOT_FOUND;
return volume_metadata_.at({volume, type});
}

Property
MeshManager::get_surface_property(MeshID surface, PropertyType type) const
{
if (surface_metadata_.count({surface, type}) == 0)
if (surface_metadata_.count({surface, type}) == 0)
return {PropertyType::BOUNDARY_CONDITION, "transmission"};
return surface_metadata_.at({surface, type});
}
Expand Down