Adding example - #227
Conversation
…void creating seperate examples for different mesh managers
|
@pshriwise I think this is ready for a review. |
Co-authored-by: Waqar Butt <114666466+Waqar-ukaea@users.noreply.github.com>
|
I just noticed that one of the example in tools have used argument parser. Maybe it will be better to take advantage of that? Let me know if you don't like the changes. |
pshriwise
left a comment
pshriwise
left a comment
There was a problem hiding this comment.
A few thoughts from me as well.
To give the example some purpose, I wonder if a Monte Carlo volume estimation using the XDG methods would be interesting.
|
Agreed. I will update this and make it a volume estimation example. |
| endif() | ||
|
|
||
| target_link_libraries(xdg PRIVATE fmt::fmt) | ||
| target_link_libraries(xdg PUBLIC fmt::fmt) |
There was a problem hiding this comment.
Can you remind me why this is necessary again?
There was a problem hiding this comment.
The issue was that fmt was linked privately to xdg. As a result, when a library or executable linked against xdg, the fmt dependency was not propagated to it. That caused the linker error we were seeing at that time.
3 participants
closes #87
I am opening to this PR to test if I am breaking anything or not since, I haven't build xdg locally yet.