Skip to content

Extend vk probe to check for required Vulkan RT extensions - #230

Merged
pshriwise merged 3 commits into
xdg-org:mainfrom
Waqar-ukaea:extend-vk-probe
May 14, 2026
Merged

Extend vk probe to check for required Vulkan RT extensions#230
pshriwise merged 3 commits into
xdg-org:mainfrom
Waqar-ukaea:extend-vk-probe

Conversation

@Waqar-ukaea

@Waqar-ukaea Waqar-ukaea commented May 12, 2026

Copy link
Copy Markdown
Collaborator

PR to close out #229 (more information enclosed in issue) and add GPRT to the CI build matrix. GPRT testing will of course still be skipped since there is no gpu available on the runners.

@Waqar-ukaea

Copy link
Copy Markdown
Collaborator Author

Playing around with setting up a CI matrix for ray tracing backends in 1f1aa89 but I may just go ahead and revert to how it was before

@Waqar-ukaea

Copy link
Copy Markdown
Collaborator Author

CI failing because GPRT is being built as a static library inside the runner which is causing it to fail in linking some NVIDIA library stuff (namely DLSS I believe). So the fix here is to build GPRT as a shared library and update the CMakeLists.txt to properly handle that too.

@Waqar-ukaea Waqar-ukaea changed the title Extend vk probe Extend vk probe and add GPRT to build matrix in CI May 13, 2026
@Waqar-ukaea

Copy link
Copy Markdown
Collaborator Author

Extending the CI matrix to also build GPRT is proving to be quite painful in all honesty. I feel like I am jumping through all sorts of hacky hoops just to get it to compile on the runner. Starting to question whether or not its even worth it at this point.

@pshriwise

pshriwise commented May 13, 2026

Copy link
Copy Markdown
Collaborator

Extending the CI matrix to also build GPRT is proving to be quite painful in all honesty. I feel like I am jumping through all sorts of hacky hoops just to get it to compile on the runner. Starting to question whether or not its even worth it at this point.

Okay. Let's not let it hold this up then. The intent is for it to be a simple improvment. Let's remove the CI changes and tackle it in a separate effort.

@Waqar-ukaea

Copy link
Copy Markdown
Collaborator Author

Okay. Let's not let it hold this up then. The intent is for it to be a simple improvment. Let's remove the CI changes and tackle it in a separate effort.

I wrote that comment just before I pushed one last change yesterday thinking it would fail to compile again but it actually did compile and shows the tests skipping as they should, so I might actually be there already. Whether or not you feel the changes I have made to the different CMakeLists.txt is reasonable I guess is a different question.

Total Test time (real) =   7.93 sec

The following tests did not run:
	 12 - test_ray_fire::Ray Fire on MeshMock (per-backend sections) - GPRT_Raytracer (Skipped)
	 14 - test_point_in_volume::Point-in-volume on MeshMock - GPRT_Raytracer (Skipped)
	 33 - test_xdg_interface::XDG Factory Creation - std::pair<MOAB_Interface, GPRT_Raytracer> (Skipped)
	 35 - test_xdg_interface::XDG Factory Creation - std::pair<LibMesh_Interface, GPRT_Raytracer> (Skipped)
	 37 - test_xdg_interface::XDG Constructor - std::pair<MOAB_Interface, GPRT_Raytracer> (Skipped)
	 39 - test_xdg_interface::XDG Constructor - std::pair<LibMesh_Interface, GPRT_Raytracer> (Skipped)
	 41 - test_xdg_interface::XDG Query API - std::pair<MOAB_Interface, GPRT_Raytracer> (Skipped)
	 43 - test_xdg_interface::XDG Query API - std::pair<LibMesh_Interface, GPRT_Raytracer> (Skipped)
	 56 - test_moab::Test BVH Build - GPRT_Raytracer (Skipped)
	 58 - test_moab::Test Ray Fire MOAB (all built backends) - GPRT_Raytracer (Skipped)

Finally the CI is still failing because GPRT isn't respecting its own CMake setting GPRT_BUILD_SHARED. When this variable is set to on it should build GPRT as a shared library but this is not the case with GPRT still building a static library. I have a PR open to address this - gprt-org/GPRT#84

So I think you're right, for now the best option will be to close this PR without the CI changes and update the CI at a later date.

@Waqar-ukaea Waqar-ukaea changed the title Extend vk probe and add GPRT to build matrix in CI Extend vk probe to check for required Vulkan RT extensions May 14, 2026
@Waqar-ukaea

Copy link
Copy Markdown
Collaborator Author

This branch should now be reverted back to before any of the CI changes were in place and is probably ready to merge if you are happy @pshriwise

@pshriwise

Copy link
Copy Markdown
Collaborator

Minor conflict to address here now @Waqar-ukaea.

@Waqar-ukaea

Copy link
Copy Markdown
Collaborator Author

@pshriwise should be good now

@pshriwise pshriwise left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from here. Thanks!

@pshriwise
pshriwise merged commit 1c16774 into xdg-org:main May 14, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Adding the check for Vulkan capable device directly to GPRTRayTracer

2 participants