Extend vk probe to check for required Vulkan RT extensions - #230
Conversation
|
Playing around with setting up a CI matrix for ray tracing backends in 1f1aa89 but I may just go ahead and revert to how it was before |
|
CI failing because GPRT is being built as a static library inside the runner which is causing it to fail in linking some NVIDIA library stuff (namely DLSS I believe). So the fix here is to build GPRT as a shared library and update the CMakeLists.txt to properly handle that too. |
|
Extending the CI matrix to also build GPRT is proving to be quite painful in all honesty. I feel like I am jumping through all sorts of hacky hoops just to get it to compile on the runner. Starting to question whether or not its even worth it at this point. |
Okay. Let's not let it hold this up then. The intent is for it to be a simple improvment. Let's remove the CI changes and tackle it in a separate effort. |
I wrote that comment just before I pushed one last change yesterday thinking it would fail to compile again but it actually did compile and shows the tests skipping as they should, so I might actually be there already. Whether or not you feel the changes I have made to the different CMakeLists.txt is reasonable I guess is a different question. Finally the CI is still failing because GPRT isn't respecting its own CMake setting So I think you're right, for now the best option will be to close this PR without the CI changes and update the CI at a later date. |
dd2f7e9 to
aaf89e8
Compare
|
This branch should now be reverted back to before any of the CI changes were in place and is probably ready to merge if you are happy @pshriwise |
aaf89e8 to
a327db3
Compare
|
Minor conflict to address here now @Waqar-ukaea. |
a327db3 to
07a4bc0
Compare
|
@pshriwise should be good now |
pshriwise
left a comment
There was a problem hiding this comment.
Looks good from here. Thanks!
PR to close out #229 (more information enclosed in issue) and add GPRT to the CI build matrix. GPRT testing will of course still be skipped since there is no gpu available on the runners.